Page MenuHomePhabricator
Create Task
Maniphest T100824

Background for description editor should be consistent between wikitext and VE
Closed, ResolvedPublic
Actions

Description

Currently, the "edit description" editor has a gray background when VE is used and a white background when wikitext is used. The background color should be consistent. I would argue for white because 1) it makes it clearer that you're editing, and 2) that's what's consistently used for editing comments.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Flowmaster+2 -1Force white background for both VE and wikitext editors
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.May 29 2015, 6:46 PM
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added projects: StructuredDiscussions, Collaboration-Team-Triage.
Catrope added subscribers: Aklapper, Catrope, Pginer-WMF.
Catrope mentioned this in T100790: Loading noJS edit pages with JS enabled (e.g. in new tab) causes wikitext to be loaded into VE.May 29 2015, 6:54 PM
gerritbot added a subscriber: gerritbot.May 29 2015, 11:49 PM

Change 214782 had a related patch set uploaded (by Catrope):
Force white background for both VE and wikitext editors

https://gerrit.wikimedia.org/r/214782

gerritbot added a project: Patch-For-Review.May 29 2015, 11:49 PM
Catrope claimed this task.May 29 2015, 11:49 PM
Catrope added a project: Collaboration-Team-Sprint-B-2015-05-20.
Catrope set Security to None.
Catrope moved this task from Sprint B - ends May 27 to Needs Review on the Collaboration-Team-Sprint-B-2015-05-20 board.
Pginer-WMF added a comment.Jun 1 2015, 8:19 AM

I would argue for white

Yes, it should be white. The change looks good to me.

I recall this was an issue that was fixed in the past, but maybe just for the wikitext editor.

matthiasmullie moved this task from Needs Review to QA Review on the Collaboration-Team-Sprint-B-2015-05-20 board.Jun 1 2015, 2:41 PM
gerritbot added a comment.Jun 1 2015, 2:43 PM

Change 214782 merged by jenkins-bot:
Force white background for both VE and wikitext editors

https://gerrit.wikimedia.org/r/214782

Diffusion mentioned this in rMEXT9913ae4fa661: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Jun 1 2015, 2:44 PM
Catrope mentioned this in rEFLWe18a6b184fd2: Force white background for both VE and wikitext editors.Jun 1 2015, 2:44 PM
DannyH closed this task as Resolved.Jun 2 2015, 12:54 AM
DannyH added a subscriber: DannyH.

Works on Beta

DannyH moved this task from QA Review to Done on the Collaboration-Team-Sprint-B-2015-05-20 board.Jun 2 2015, 12:55 AM
DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL