Page MenuHomePhabricator

Highlights too tall for focusable nodes that contain scrollable areas
Closed, ResolvedPublic1 Estimated Story Points

Description

See https://ru.wikipedia.org/wiki/Участник:Roan_Kattouw_(WMF)/Sandbox?veaction=edit . The highlight is too tall and contains a few weird rectangles. I think this might be due to the scrollable parts of the infobox.

Event Timeline

Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)

Ugh. I guess we should not descend into nodes with overflow hidden or scroll which means doing computed CSS...

HTML to reproduce in standalone:

<div rel="ve:Alien" style="overflow:scroll; width: 100px; height: 100px;"><div style="width: 200px; height: 200px; background: #fee;">Hi</div></div>

Change 236262 had a related patch set uploaded (by Esanders):
Don't descend into overflow clipped nodes for highlights

https://gerrit.wikimedia.org/r/236262

Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Change 236262 merged by jenkins-bot:
Don't descend into overflow clipped nodes for highlights

https://gerrit.wikimedia.org/r/236262