Page MenuHomePhabricator

API action=query&list=categorymembers logs the usage of deprecated cmstartsortkey parameter even when that parameter is not used
Closed, ResolvedPublic

Description

Title says it all.

See for example api.php?action=query&list=categorymembers&cmtitle=Category%3AValuable%20pages (replace the category with something that exists). There are calls to $this->logFeatureUsage( 'list=categorymembers&cmstartsortkey' ); and $this->logFeatureUsage( 'list=categorymembers&cmendsortkey' ); which don't seem relevant here, as those parameters were not passed in.

If the calls are meant to be there, the API help needs to be fixed to explain what's going on here.

Event Timeline

TTO created this task.May 30 2015, 10:16 AM
TTO raised the priority of this task from to Needs Triage.
TTO updated the task description. (Show Details)
TTO added a project: MediaWiki-API.
TTO added subscribers: TTO, Anomie.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2015, 10:16 AM

Change 214825 had a related patch set uploaded (by Umherirrender):
list=categorymembers: Do not log feature usage when using default value

https://gerrit.wikimedia.org/r/214825

Anomie closed this task as Resolved.May 31 2015, 5:07 PM

Should go out to WMF wikis with 1.26wmf9.

Change 214825 merged by jenkins-bot:
list=categorymembers: Do not log feature usage when using default value

https://gerrit.wikimedia.org/r/214825