Page MenuHomePhabricator

Blacklist Safari<5.1 from receiving JavaScript in the startup module
Closed, DeclinedPublic


We should blacklist Safari<5.1 from receiving JavaScript. My immediate motivation is T75734.

According to this should already be the case, but it isn't.

Event Timeline

matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added subscribers: Krinkle, Jdforrester-WMF.

This will get done by way of T128115.

Per T128115#3082019, it looks like Safari 5.1 does consistently pass. Safari 5.0 got pretty messy on iOS with regards to backports. I don't really know what's going on there. Even the same exact UA strings are showing up as both fail and pass. Same OS, same built-in Safari version, same built-in WebKit build, even in the same mode ("Safari" and embedded app WebView have different UA strings).

@matmarex This task calls for blacklisting "Safari < 5.1", I assume that means Safari 5.0.x and earlier. However, the mentioned T75734 is about Mobile Safari on iOS 5.1.1. I guess iOS 5.1.x came with Mobile Safari 5.0.x? The data I have confirms this but just wanted to double check. (The 5.x releases are confusing since the browser and OS versions coincided.)

Perhaps, I was probably confused. I only know as much as is written in T75734.

You know, I'm not sure how this would help at all for T75734… does anyone have any idea what I might have been thinking? This task seems to make no sense at all.

@Jdforrester-WMF iOS 5.1.1 runs Mobile Safari 5.0, not 5.1. So < was right, I guess.

@matmarex If I understand T75734 correctly, it is about mediawiki.ui and stylesheets, which will be required even for Grade C, which Safari 5.0 will be supported as for a while considering we're only just about to drop it from Grade A - presumably it is not affected by JavaScript? Or does this bug not happen with the oojs-ui core stylesheet?

Closing this for now..