Page MenuHomePhabricator
Create Task
Maniphest T100906

Message dialog's non-last vertical buttons' hover highlights are misaligned
Closed, ResolvedPublic
Actions

Description

See screenshot. Doesn't seem to impact the last button in vertical layout, or any buttons in horizontal layout.

Screen Shot 2015-05-30 at 12.14.35.png (252×321 px, 17 KB)

Details

SubjectRepoBranchLines +/-
MessageDialog: Remove unintentional action button marginoojs/uimaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.May 30 2015, 7:18 PM
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a project: OOUI.
Jdforrester-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2015, 7:18 PM
matmarex claimed this task.May 31 2015, 7:12 PM
gerritbot subscribed.May 31 2015, 7:16 PM

Change 214932 had a related patch set uploaded (by Bartosz Dziewoński):
MessageDialog: Remove unintentional margin

https://gerrit.wikimedia.org/r/214932

gerritbot added a project: Patch-For-Review.May 31 2015, 7:16 PM
Jdforrester-WMF closed this task as Resolved.May 31 2015, 7:23 PM
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF set Security to None.
gerritbot added a comment.May 31 2015, 7:26 PM

Change 214932 merged by jenkins-bot:
MessageDialog: Remove unintentional action button margin

https://gerrit.wikimedia.org/r/214932

matmarex mentioned this in rGOJU79d86f3cbad7: MessageDialog: Remove unintentional action button margin.May 31 2015, 7:26 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.May 31 2015, 11:01 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.11.4), WMF-deploy-2015-06-16_(1.26wmf10); removed OOjs-UI-next-release.Jun 9 2015, 10:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL