Page MenuHomePhabricator
Create Task
Maniphest T100928

pywikibot.page.isDisambig depends on disambiguationspage
Closed, ResolvedPublic
Actions

Description

When run against an empty instance using a family file generated by the family file generator

ERROR: Test various methods that rely on API.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/jayvdb/pywikibot-core/tests/page_tests.py", line 403, in testApiMethods
    self.assertIsInstance(mainpage.isDisambig(), bool)
  File "/home/travis/build/jayvdb/pywikibot-core/pywikibot/page.py", line 800, in isDisambig
    'disambiguationspage').split(':', 1)[1]
  File "/home/travis/build/jayvdb/pywikibot-core/pywikibot/site.py", line 1955, in mediawiki_message
    return self.mediawiki_messages([key])[key]
  File "/home/travis/build/jayvdb/pywikibot-core/pywikibot/site.py", line 1943, in mediawiki_messages
    % (self, key))
nose.proxy.KeyError: "Site pwbtest:en has no message 'disambiguationspage'"

https://travis-ci.org/jayvdb/pywikibot-core/jobs/64686164#L640

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
[bugfix] Fallback to default if mw message 'disambiguationspage' doesn't existsMerlijn van Deenpywikibot/core2.0+3 -1
[bugfix] Fallback to default if mw message 'disambiguationspage' doesn't existsXqtpywikibot/coremaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

jayvdb created this task.May 31 2015, 11:09 AM
jayvdb raised the priority of this task from to Medium.
jayvdb updated the task description. (Show Details)
jayvdb added projects: Pywikibot-tests, Pywikibot.
jayvdb added subscribers: gerritbot, Unknown Object (MLST), Ladsgroup and 2 others.
Xqt subscribed.Jul 5 2015, 9:03 AM

What to do with it. Seems this wiki doesn't have any disambig configurated. Should use the default template at the end. Isn't it?

jayvdb added a comment.Jul 5 2015, 9:22 AM

Yes, it is an empty wiki, without any family configuration.
I am thinking that if there is no way to know if the page is a Disambig page, issue a FamilyMaintenanceWarning, and return False.

gerritbot added a comment.Jul 5 2015, 9:25 AM

Change 222881 had a related patch set uploaded (by Xqt):
[bugfix] Fallback to default if mw message 'disambiguationspage' doesn't exists

https://gerrit.wikimedia.org/r/222881

gerritbot added a project: Patch-For-Review.Jul 5 2015, 9:25 AM
Xqt claimed this task.Jul 5 2015, 9:28 AM
gerritbot added a comment.Jul 5 2015, 1:05 PM

Change 222881 merged by jenkins-bot:
[bugfix] Fallback to default if mw message 'disambiguationspage' doesn't exists

https://gerrit.wikimedia.org/r/222881

Xqt mentioned this in rPWBC366d2fd38135: [bugfix] Fallback to default if mw message 'disambiguationspage' doesn't exists.Jul 5 2015, 1:05 PM
jayvdb closed this task as Resolved.Jul 5 2015, 1:23 PM
gerritbot added a comment.Jul 9 2015, 6:44 PM

Change 223879 had a related patch set uploaded (by Merlijn van Deen):
[bugfix] Fallback to default if mw message 'disambiguationspage' doesn't exists

https://gerrit.wikimedia.org/r/223879

gerritbot added a comment.Jul 9 2015, 7:55 PM

Change 223879 merged by jenkins-bot:
[bugfix] Fallback to default if mw message 'disambiguationspage' doesn't exists

https://gerrit.wikimedia.org/r/223879

valhallasw mentioned this in rPWBC06a0b08d16b3: [bugfix] Fallback to default if mw message 'disambiguationspage' doesn't exists.Jul 9 2015, 7:55 PM
Xqt removed a parent task: T100802: Run test against an empty MediaWiki instance.Aug 2 2023, 10:12 AM
Xqt closed subtask T104800: default disambiguationspage message not correctly parsed for ~10 languages as Resolved.Aug 2 2023, 10:18 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 2 2023, 10:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits