automatic login to private wiki raises APIError on the second failed login
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	jayvdb
	Jun 1 2015, 6:08 AM

Description

If an automatic login to a private (read denied) is attempted twice, the first action will raise NoUsername, but the second login will raise APIError.

Details

	Subject	Repo	Branch	Lines +/-
	[FIX] APISite: Reset loginstatus	pywikibot/core	master	+27 -23
	site._loginstatus - login process and caching	pywikibot/core	master	+220 -38

Customize query in gerrit

Related Objects

Mentioned In: T248471: login() with retry=True might delete correct password if unknown APIError occurs
T248945: api_tests based on TestLazyLoginBase are failing
Mentioned Here: T71283: dualism between user and sysop needs to be overtaken

Event Timeline

jayvdb created this task.Jun 1 2015, 6:08 AM

jayvdb raised the priority of this task from to High.

jayvdb updated the task description. (Show Details)

jayvdb added projects: Pywikibot, Pywikibot-login.py.

jayvdb added subscribers: Unknown Object (MLST), jayvdb, Aklapper.

I'm currently guessing but it does sort of make sense. The second APIError happens probably because after the first failed login the API knows that login doesn't work and doesn't attempt to login but just reraises the possible APIError caught in the first attempt.

Ah the site's _loginstatus is -2 (IN_PROGRESS). Seems like the status is not properly changed.

Change 215000 had a related patch set uploaded (by XZise):
[FIX] APISite: Reset loginstatus

https://gerrit.wikimedia.org/r/215000

gerritbot added a project: Patch-For-Review.Jun 1 2015, 10:44 AM

XZise claimed this task.Jun 1 2015, 11:02 AM

Change 143038 had a related patch set uploaded (by John Vandenberg):
site._loginstatus - login process and caching

https://gerrit.wikimedia.org/r/143038

xSavitar moved this task from Backlog to Needs Review on the Pywikibot board.Nov 5 2018, 11:36 AM

Xqt mentioned this in T248945: api_tests based on TestLazyLoginBase are failing.Mar 31 2020, 9:45 AM

Xqt removed XZise as the assignee of this task.Mar 31 2020, 3:47 PM

Dvorapa mentioned this in T248471: login() with retry=True might delete correct password if unknown APIError occurs.Mar 31 2020, 5:09 PM

Judging by the associated patch, this was related to the "sysopnames" feature of bot logins, which we have since deprecated and removed (see T71283). I am going to mark it as Invalid given how much the code has moved forward since this task was created. Can always be reopened if the issue still matters.

I can see only a little sysopnames connection here or in the patch. The whole point is resetting the login status on failure, which is a clever idea. But anyway issues like these are still present, but the output changed since then drastically so it would be hard to recognize the newly occuring issue is a dupe of this one.

Change 143038 abandoned by Xqt:
site._loginstatus - login process and caching

Reason:
very outdated

https://gerrit.wikimedia.org/r/143038

Change 215000 abandoned by Xqt:
[FIX] APISite: Reset loginstatus

Reason:
already solved