Page MenuHomePhabricator
Create Task
Maniphest T101014

Remove unused JavaScript from GlobalCollect gateway
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

While researching T86214, I found and tripped over a bunch of JavaScript that was intended to do client side validation of the GlobalCollect form, but looks like it was never implemented and is currently unused. Removing it to reduce clutter.

Details

SubjectRepoBranchLines +/-
Remove Unused Javascript from GlobalCollect gatewaymediawiki/extensions/DonationInterfacemaster+0 -2 K
Customize query in gerrit

Related Objects

Event Timeline

XenoRyet created this task.Jun 1 2015, 6:36 PM
XenoRyet claimed this task.
XenoRyet raised the priority of this task from to Medium.
XenoRyet updated the task description. (Show Details)
XenoRyet added a project: Fundraising Sprint Lou Reed.
XenoRyet subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2015, 6:36 PM
XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint Lou Reed board.Jun 1 2015, 6:36 PM
XenoRyet set Security to None.
XenoRyet edited a custom field.
gerritbot subscribed.Jun 1 2015, 10:22 PM

Change 215218 had a related patch set uploaded (by XenoRyet):
Remove Unused Javascript from GlobalCollect gateway

https://gerrit.wikimedia.org/r/215218

gerritbot added a project: Patch-For-Review.Jun 1 2015, 10:22 PM
XenoRyet moved this task from Doing to Review on the Fundraising Sprint Lou Reed board.Jun 1 2015, 10:24 PM
gerritbot added a comment.Jun 1 2015, 10:35 PM

Change 215218 merged by jenkins-bot:
Remove Unused Javascript from GlobalCollect gateway

https://gerrit.wikimedia.org/r/215218

awight mentioned this in rEDOI4b4355480ee3: Remove Unused Javascript from GlobalCollect gateway.Jun 1 2015, 10:35 PM
XenoRyet mentioned this in rMEXT20b65915a9e6: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jun 1 2015, 10:35 PM
XenoRyet moved this task from Review to Done on the Fundraising Sprint Lou Reed board.Jun 2 2015, 8:40 PM
• atgo closed this task as Resolved.Jun 8 2015, 9:33 PM
• atgo subscribed.

Closing because it seems done.

• atgo edited a custom field.Jun 8 2015, 9:33 PM

No points for unplanned work :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL