Page MenuHomePhabricator
Create Task
Maniphest T101035

Mobile thanks button misplaced in MobileDiff
Closed, ResolvedPublic
Actions

Description

See this example:

Steps to reproduce:
Find a page with changes of another person

  • click history link
  • click one revision to see the mobile unified diff page
  • thanks button is misplaced

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+4 -1Float thanks link to right
Customize query in gerrit

Related Objects

Event Timeline

Florian created this task.Jun 1 2015, 9:28 PM
Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added projects: Readers-Web-Backlog, Thanks.
Florian added a subscriber: Florian.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 1 2015, 9:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson added a subscriber: Jdlrobson.Jun 2 2015, 7:49 PM

Sigh. Not again!! :)

Jdlrobson moved this task from Incoming to 2016-17 Q2 on the Readers-Web-Backlog board.Jun 2 2015, 7:49 PM
KLans_WMF moved this task from 2016-17 Q2 to 2015-16 Q3 on the Readers-Web-Backlog board.Jun 17 2015, 6:50 PM
Jdlrobson added a project: Reading-Web-Sprint-50-The-X-Files.Jun 17 2015, 7:08 PM
Jdlrobson set Security to None.
KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 4:26 PM
Jdlrobson claimed this task.Jun 22 2015, 6:08 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-50-The-X-Files board.
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 6:31 PM
gerritbot added a subscriber: gerritbot.Jun 22 2015, 6:32 PM

Change 219885 had a related patch set uploaded (by Jdlrobson):
Float thanks link to right

https://gerrit.wikimedia.org/r/219885

gerritbot added a project: Patch-For-Review.Jun 22 2015, 6:32 PM
bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 8:37 PM
gerritbot added a comment.Jun 22 2015, 8:39 PM

Change 219885 merged by jenkins-bot:
Float thanks link to right

https://gerrit.wikimedia.org/r/219885

• Konfused-Kitten mentioned this in rEMFRe70d6690cdca: Float thanks link to right.Jun 22 2015, 8:39 PM
Diffusion mentioned this in rMEXT847582da004d: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 22 2015, 8:40 PM
Jdlrobson merged a task: T103609: Icons in diff footers are misaligned.Jun 23 2015, 10:00 PM
Jdlrobson added a subscriber: • KHammerstein.
phuedx closed this task as Resolved.Jun 25 2015, 10:11 AM
phuedx added a subscriber: phuedx.

Verified on BC with a simulated iPhone 6 and iPhone 4 – I was curious about smaller screen sizes.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-50-The-X-Files board.Jun 25 2015, 10:11 AM
phuedx mentioned this in T103393: Diff information clipped.Jun 25 2015, 12:25 PM
phuedx removed a project: Patch-For-Review.Jun 26 2015, 10:32 AM
DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jun 30 2015, 7:57 PM
Phabricator_maintenance moved this task from 2015-16 Q3 to 2014-15 Q4 on the Readers-Web-Backlog board.Mar 7 2018, 1:19 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL