Page MenuHomePhabricator
Create Task
Maniphest T101035

Mobile thanks button misplaced in MobileDiff
Closed, ResolvedPublic
Actions

Description

See this example:

Steps to reproduce:
Find a page with changes of another person

  • click history link
  • click one revision to see the mobile unified diff page
  • thanks button is misplaced

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+4 -1Float thanks link to right
Customize query in gerrit

Related Objects

Event Timeline

Florian created this task.Jun 1 2015, 9:28 PM
Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added projects: Readers-Web-Backlog, Thanks.
Florian added a subscriber: Florian.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 1 2015, 9:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson added a subscriber: Jdlrobson.Jun 2 2015, 7:49 PM

Sigh. Not again!! :)

Jdlrobson claimed this task.Jun 22 2015, 6:08 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-50-The-X-Files board.
gerritbot added a subscriber: gerritbot.Jun 22 2015, 6:32 PM

Change 219885 had a related patch set uploaded (by Jdlrobson):
Float thanks link to right

https://gerrit.wikimedia.org/r/219885

gerritbot added a comment.Jun 22 2015, 8:39 PM

Change 219885 merged by jenkins-bot:
Float thanks link to right

https://gerrit.wikimedia.org/r/219885

phuedx closed this task as Resolved.Jun 25 2015, 10:11 AM
phuedx added a subscriber: phuedx.

Verified on BC with a simulated iPhone 6 and iPhone 4 – I was curious about smaller screen sizes.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL