Page MenuHomePhabricator

PDF generation does not work on private wikis
Closed, DuplicatePublic

Description

Attempting to generate PDFs on private wikis (for example, https://otrs-wiki.wikimedia.org) does not work, because cookie forwarding is not (yet) supported by the bundler or by the Collection extension.

Event Timeline

Rjd0060 created this task.Jun 1 2015, 11:28 PM
Rjd0060 raised the priority of this task from to Needs Triage.
Rjd0060 updated the task description. (Show Details)
Rjd0060 added subscribers: Rjd0060, MZMcBride, Krenair, Az1568.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2015, 11:28 PM

@Rjd0060: Is this any different from T94308 or should T101052 be merged as a duplicate into T94308 ?

To be honest T94308 needs to be split up, with @Mdann52's merges completely reversed.

This is probably a new issue caused by the RESTBase migration (T93292). cc'ing @GWicke.

Could you make this bug more concrete, please? Give me a specific uncomplicated page on a specific private wiki, and I can probably figure out what's going on.

This is probably a new issue caused by the RESTBase migration (T93292). cc'ing @GWicke.

Could you make this bug more concrete, please? Give me a specific uncomplicated page on a specific private wiki, and I can probably figure out what's going on.

@cscott, Here's an example page https://otrs-wiki.wikimedia.org/wiki/Help:FAQ

But as I stated, any page will do, from any private wiki apparently.

I investigated. It appears the VE is using the Parsoid API, but using the cookie-forwarding provided by VRS. See:
https://github.com/wikimedia/mediawiki/blob/b13bd0996cbd0b179d869dc25bd22c17a1633995/includes/libs/virtualrest/ParsoidVirtualRESTService.php#L118

So OCG would have to add support for similar cookie fowarding, presumably by passing the cookies as part of the metabook JSON.

cscott updated the task description. (Show Details)Jun 11 2015, 8:04 PM
cscott set Security to None.