Page MenuHomePhabricator
Create Task
Maniphest T101074

Set up phpcs for Echo
Closed, ResolvedPublic
Actions

Description

Would have caught things like https://gerrit.wikimedia.org/r/215260

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Run phpcs through "composer test", disabling failing rulesmediawiki/extensions/Echomaster+31 -2
Customize query in gerrit

Event Timeline

Legoktm created this task.Jun 2 2015, 1:06 AM
Legoktm raised the priority of this task from to Medium.
Legoktm updated the task description. (Show Details)
Legoktm added a project: Notifications (Echo).
Legoktm subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 2 2015, 1:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Jun 2 2015, 1:46 AM

Change 215269 had a related patch set uploaded (by Legoktm):
[WIP] Run phplint and phpcs through "composer test"

https://gerrit.wikimedia.org/r/215269

gerritbot added a project: Patch-For-Review.Jun 2 2015, 1:46 AM
Legoktm moved this task from Backlog to Needs code on the Notifications (Echo) board.Jul 6 2015, 7:23 AM
gerritbot added a comment.Oct 29 2015, 4:35 PM

Change 215269 merged by jenkins-bot:
Run phpcs through "composer test", disabling failing rules

https://gerrit.wikimedia.org/r/215269

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Oct 29 2015, 5:00 PM
Catrope closed this task as Resolved.Feb 13 2016, 12:27 AM
Catrope claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits