Page MenuHomePhabricator
Create Task
Maniphest T101114

Astropay form is autofilling email to "nobody@wikimedia.org"
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Finish removing hardcoded nobody@wikimedia.orgmediawiki/extensions/DonationInterfacemaster+5 -5
Stage email first, use staged for dependent valuesmediawiki/extensions/DonationInterfacemaster+6 -6
Customize query in gerrit

Related Objects

Event Timeline

• atgo created this task.Jun 2 2015, 3:59 PM
• atgo assigned this task to Ejegg.
• atgo raised the priority of this task from to High.
• atgo updated the task description. (Show Details)
• atgo added projects: [DO NOT USE] Astropay [superseded by #FR-Astropay], Fundraising Sprint Lou Reed.
• atgo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2015, 3:59 PM
gerritbot subscribed.Jun 2 2015, 4:04 PM

Change 215341 had a related patch set uploaded (by Ejegg):
Finish removing hardcoded nobody@wikimedia.org

https://gerrit.wikimedia.org/r/215341

gerritbot added a project: Patch-For-Review.Jun 2 2015, 4:04 PM
• atgo moved this task from Backlog to Done on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.Jun 2 2015, 4:06 PM
• atgo moved this task from Done to Required for donor testing on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.
Ejegg added a comment.Jun 2 2015, 4:06 PM

Yep, there was an odd quirk where we set a default value for email right at the start of the process. The old forms had a special workaround, hardcoding a "nobody@wikimedia" exception into the token replacement code. https://gerrit.wikimedia.org/r/215245 moves setting the default to later in the process, and https://gerrit.wikimedia.org/r/215341 finishes cleaning up the old form code.

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Lou Reed board.Jun 2 2015, 4:12 PM
gerritbot added a comment.Jun 3 2015, 7:59 PM

Change 215710 had a related patch set uploaded (by Ejegg):
Stage email first, use staged for dependent values

https://gerrit.wikimedia.org/r/215710

gerritbot added a comment.Jun 3 2015, 8:38 PM

Change 215710 merged by jenkins-bot:
Stage email first, use staged for dependent values

https://gerrit.wikimedia.org/r/215710

Ejegg mentioned this in rMEXT7403b349f185: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jun 3 2015, 8:38 PM
Ejegg mentioned this in rEDOI12b4ebdc9100: Stage email first, use staged for dependent values.
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Lou Reed board.Jun 3 2015, 10:08 PM
gerritbot added a comment.Jun 3 2015, 10:25 PM

Change 215341 merged by jenkins-bot:
Finish removing hardcoded nobody@wikimedia.org

https://gerrit.wikimedia.org/r/215341

Ejegg mentioned this in rMEXTf5694551276d: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jun 3 2015, 10:25 PM
awight mentioned this in rEDOI701cf0ad0128: Finish removing hardcoded nobody@wikimedia.org.Jun 3 2015, 10:25 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Lou Reed board.Jun 4 2015, 10:41 PM
Ejegg closed this task as Resolved.Jun 4 2015, 10:43 PM
Ejegg set Security to None.
• atgo moved this task from Required for donor testing to Done on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.Jun 8 2015, 5:47 PM
• DStrine added a project: FR-dlocal.Dec 14 2015, 7:15 PM
• atgo unsubscribed.Mar 30 2016, 10:13 PM
• Phabricator_maintenance removed a project: [DO NOT USE] Astropay [superseded by #FR-Astropay].Aug 10 2016, 11:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits