Page MenuHomePhabricator
Create Task
Maniphest T101115

Anon users can access public view from main menu
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

When anonymous and I click collections I am taken to the public view (instead of being prompted to log in).

Details

SubjectRepoBranchLines +/-
Collections link for anon takes user to public view.mediawiki/extensions/Gathermaster+14 -2
Collections link for anon takes user to public view.mediawiki/extensions/Gathermaster+14 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JKatzWMF created this task.Jun 2 2015, 3:59 PM
• JKatzWMF raised the priority of this task from to Needs Triage.
• JKatzWMF updated the task description. (Show Details)
• JKatzWMF added a project: Gather.
• JKatzWMF moved this task to Must haves on the Gather board.
• JKatzWMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2015, 3:59 PM
Jdlrobson subscribed.Jun 2 2015, 7:23 PM

In T96222 there is a 'my collections' do anons see this? Does it prompt them to login?

Jdlrobson added a subtask: T96222: Add a new public collection feed view.Jun 2 2015, 7:23 PM
Jdlrobson updated the task description. (Show Details)Jun 2 2015, 7:27 PM
Jdlrobson set Security to None.
• JKatzWMF updated the task description. (Show Details)Jun 2 2015, 7:28 PM
Jdlrobson removed a subtask: T101150: Create collection button shown to anons on public view.Jun 2 2015, 7:30 PM
Jdlrobson updated the task description. (Show Details)Jun 2 2015, 7:36 PM
Jdlrobson edited a custom field.Jun 2 2015, 7:42 PM
• KLans_WMF added projects: Mobile-Web-Sprint-49-Wayne's-World, Web-Team-Backlog.Jun 2 2015, 7:43 PM
• KLans_WMF moved this task from Incoming to 2015-16 Q3 on the Web-Team-Backlog board.
Jdlrobson renamed this task from Anon users can access public view to Anon users can access public view from main menu.Jun 8 2015, 4:26 PM
kaldari updated the task description. (Show Details)Jun 8 2015, 4:27 PM
• KLans_WMF moved this task from Needs Analysis to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 8 2015, 4:28 PM
• Jhernandez subscribed.Jun 8 2015, 4:28 PM

Yes. Show the my collections tab with the new button (that when clicked goes to login).

• KLans_WMF moved this task from Doing to To Do on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 8 2015, 4:29 PM
Jdlrobson claimed this task.Jun 11 2015, 9:46 PM
Jdlrobson moved this task from To Do to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.
gerritbot subscribed.Jun 11 2015, 9:54 PM

Change 217715 had a related patch set uploaded (by Jdlrobson):
Collections link for anon takes user to public view.

https://gerrit.wikimedia.org/r/217715

gerritbot added a project: Patch-For-Review.Jun 11 2015, 9:54 PM
Jdlrobson moved this task from Doing to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 11 2015, 9:54 PM
• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 12 2015, 8:34 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 15 2015, 6:38 PM
Jdlrobson mentioned this in T94972: Gather pages should not simply be a totally empty if there are no collections.
• bmansurov moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 15 2015, 8:40 PM
gerritbot added a comment.Jun 16 2015, 4:53 PM

Change 217715 merged by jenkins-bot:
Collections link for anon takes user to public view.

https://gerrit.wikimedia.org/r/217715

• Konfused-Kitten mentioned this in rMEXT8cd25fd0c01d: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 16 2015, 4:53 PM
• Jhernandez mentioned this in rEGATaf08a473978e: Collections link for anon takes user to public view..Jun 16 2015, 4:54 PM
• Forrestbot added a project: WMF-deploy-2015-06-16_(1.26wmf10).Jun 16 2015, 5:00 PM
• Forrestbot subscribed.
• Jhernandez moved this task from Ready for Signoff to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 5:41 PM
Jdlrobson moved this task from -1 (Needs More Work) to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 8:21 PM

I've reverted this whilst we have issues with templating in https://phabricator.wikimedia.org/T101918

gerritbot added a comment.Jun 16 2015, 8:37 PM

Change 218730 had a related patch set uploaded (by Jdlrobson):
Collections link for anon takes user to public view.

https://gerrit.wikimedia.org/r/218730

Jdlrobson moved this task from Doing to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 8:46 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 17 2015, 5:45 PM
• KLans_WMF moved this task from 2015-16 Q3 to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Jun 17 2015, 5:56 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 17 2015, 8:53 PM
• bmansurov moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 18 2015, 10:19 AM
gerritbot added a comment.Jun 18 2015, 9:27 PM

Change 218730 merged by jenkins-bot:
Collections link for anon takes user to public view.

https://gerrit.wikimedia.org/r/218730

• Konfused-Kitten mentioned this in rMEXTf288eb594cbb: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 18 2015, 9:27 PM
• Konfused-Kitten mentioned this in rEGATa8c262e0354d: Collections link for anon takes user to public view..
phuedx closed this task as Resolved.Jun 19 2015, 2:56 PM
phuedx subscribed.

Verified locally. This ain't on BC yet though…

phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 19 2015, 2:56 PM
phuedx removed a project: Patch-For-Review.Jun 19 2015, 7:22 PM
• Jhernandez added a comment.Jun 22 2015, 11:49 AM

This is on beta-cluster and works fine.

• JKatzWMF closed subtask T96222: Add a new public collection feed view as Resolved.Jun 22 2015, 4:48 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL