The tests.http_tests.HttpsCertificateTestCase.test_https_ignore_cert_error can't fail anymore because the website tested is using a valid certificate: https://www.ssllabs.com/ssltest/analyze.html?d=en.vikidia.org
With the requests change in T98439 it might be that we don't support connections to invalid certificates anymore.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [FIX] http: Disable certificate validation | pywikibot/core | master | +27 -52 |
The easiest way to force an invalid cert error is by passing an empty cert bundle (which would make every site show up as having an invalid certificate).
Change 215507 had a related patch set uploaded (by XZise):
[FIX] http: Disable certificate validation
We also have a test for invalid certificate, test_https_cert_error, which works well, using the still invalid cert for https://www.omegawiki.org/.
The purpose of test_https_ignore_cert_error and test_https_cert_invalid was that pywikibot's threading for httplib2 failed to raise the exception on the second request to the same host, as the connection was cached.
However now we are not using httplib2 threading, we may be able to retest with https://www.omegawiki.org/ . But the approach of https://gerrit.wikimedia.org/r/#/c/215507/ , testing with a dummy certificate, would be better.