Page MenuHomePhabricator

Fix Gerrit's link handling of full URLs to Phabricator tasks
Closed, DuplicatePublic

Description

Gerrit's comments break when a full link to a phabricator task is put in them. For example, in https://gerrit.wikimedia.org/r/#/c/215502/, this happened:

https://phabricator.wikimedia.org/T90238

Gets converted to:

T90238" target="_blank">https://phabricator.wikimedia.org/T90238

Corresponding generated HTML is:

<a href="https://phabricator.wikimedia.org/&lt;a href=" https:="" phabricator.wikimedia.org="" t90238"="">T90238</a>" target="_blank"&gt;https://phabricator.wikimedia.org/<a href="https://phabricator.wikimedia.org/T90238">T90238</a>

Just the task number works fine, though. For example,

T90238

gets converted to (HTML):

<a href="https://phabricator.wikimedia.org/T90238">T90238</a>

Event Timeline

polybuildr raised the priority of this task from to Needs Triage.
polybuildr updated the task description. (Show Details)
polybuildr added a project: Gerrit.
polybuildr added a subscriber: polybuildr.
Aklapper renamed this task from Fix Gerrit's handling of Phabricator task links to Fix Gerrit's link handling of full URLs to Phabricator tasks.Jun 3 2015, 1:59 PM
Aklapper triaged this task as Lowest priority.
Aklapper removed subscribers: QChris, demon, hashar.