Page MenuHomePhabricator
Create Task
Maniphest T101165

Make the save page button flush to the toolbar
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

We need to make the save page button flush to the toolbar, this is part of T99274

Details

SubjectRepoBranchLines +/-
Make toolbar save button framelessmediawiki/extensions/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Nirzar created this task.Jun 2 2015, 8:53 PM
• Nirzar raised the priority of this task from to Needs Triage.
• Nirzar updated the task description. (Show Details)
• Nirzar added projects: VisualEditor, VisualEditor 2014/15 Q4 blockers.
• Nirzar subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2015, 8:53 PM
• Nirzar added a parent task: T99274: Emphasize VE's save button by animating the progress bar attached to the bottom of the toolbar.Jun 2 2015, 8:53 PM
Jdforrester-WMF triaged this task as Medium priority.Jun 3 2015, 5:40 PM
Jdforrester-WMF added projects: OOUI, Design, VisualEditor-MediaWiki.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Jun 3 2015, 6:08 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Jun 3 2015, 10:00 PM
Jdforrester-WMF edited projects, added VisualEditor 2015/16 Q1 blockers; removed VisualEditor 2014/15 Q4 blockers.Jun 16 2015, 10:11 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to TR1: Releases on the VisualEditor board.Jun 18 2015, 12:52 AM
Jdforrester-WMF renamed this task from Make the save page button flush to the toolbar. to Make the save page button flush to the toolbar.Jun 18 2015, 10:35 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF added a subtask: T103403: Buttons in toolbars should all be frameless.Jun 22 2015, 6:59 PM
gerritbot subscribed.Jul 1 2015, 11:13 AM

Change 222094 had a related patch set uploaded (by Esanders):
Make toolbar save button frameless

https://gerrit.wikimedia.org/r/222094

gerritbot added a project: Patch-For-Review.Jul 1 2015, 11:13 AM
Jdforrester-WMF closed this task as Resolved.Jul 1 2015, 10:46 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF closed subtask T103403: Buttons in toolbars should all be frameless as Resolved.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2015/16 Q1 blockers board.
gerritbot added a comment.Jul 1 2015, 10:48 PM

Change 222094 merged by jenkins-bot:
Make toolbar save button frameless

https://gerrit.wikimedia.org/r/222094

Esanders mentioned this in rEVEDcb11cbd2f5e3: Make toolbar save button frameless.Jul 1 2015, 10:48 PM
Jdforrester-WMF edited projects, added User-notice; removed Patch-For-Review.Jul 1 2015, 10:57 PM
• Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 1 2015, 11:00 PM
gpaumier removed a project: User-notice.Jul 2 2015, 8:17 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Jul 2 2015, 11:04 PM
matmarex mentioned this in T103403: Buttons in toolbars should all be frameless.Jul 3 2015, 10:52 AM
matmarex reopened subtask T103403: Buttons in toolbars should all be frameless as Open.
matmarex closed subtask T103403: Buttons in toolbars should all be frameless as Declined.Jul 3 2015, 12:26 PM
Jdforrester-WMF changed the status of subtask T103403: Buttons in toolbars should all be frameless from Declined to Resolved.Jul 8 2015, 3:48 PM
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL