Page MenuHomePhabricator

[Usability] Escape should cancel the link dialog and not link the word using link tool
Closed, ResolvedPublic1 Estimated Story Points

Description

When user selects a word, clicks on link tool, link inspector shows up. at this stage if user presses escape key, it should dismiss the link inspector without linking the word. currently, escape actually links the word.

Event Timeline

Nirzar raised the priority of this task from to Needs Triage.
Nirzar updated the task description. (Show Details)
Nirzar subscribed.

(@Nirzar: What's the use of the "[Usability]" prefix added to this task's summary? How is it relevant compared to other tasks not having that prefix?)

Apart from design tag, I was using [usability] in places where the item was identified as usability issue in the user testing. just a reference to what we(editing team) discussed in the triage meetings. I am sure there is a better way than [usability] tag in titles.

So, feel free to recommend :) or i can just use design tag in projects.

Jdforrester-WMF claimed this task.
Jdforrester-WMF subscribed.

This is now fixed in master (first Esc closes the search results; second Esc closes the inspector and doesn't apply the link).

Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.