Page MenuHomePhabricator
Create Task
Maniphest T101190

Main menu non-JavaScript behaviour regression
Closed, ResolvedPublic
Actions

Description

Our browser tests assert that Nearby, Uploads and Login should be hidden without JavaScript but this is not true on master.
These links are hidden because the first two do not work without JavaScript and login is disabled since there are no useful features for users without JavaScript.

Code should be updated to hide these links again if JS is disabled.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+11 -18Hide JS-only main menu links when JavaScript is off
mediawiki/extensions/MobileFrontendmaster+4 -2QA: Temporarily skip basic site scenarios
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 2 2015, 10:44 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Mobile-Web-Sprint-48-Voyage-of-the-Damned, Readers-Web-Backlog.
Jdlrobson moved this task to Needs Analysis on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2015, 10:44 PM
gerritbot added a subscriber: gerritbot.Jun 2 2015, 10:52 PM

Change 215539 had a related patch set uploaded (by Dduvall):
QA: Temporarily skip basic site scenarios

https://gerrit.wikimedia.org/r/215539

Jdlrobson renamed this task from QA: Browser tests for non-JavaScript main menu failing to Assertions in browser tests for non-JavaScript main menu failing.Jun 2 2015, 11:05 PM
Jdlrobson set Security to None.
gerritbot added a comment.Jun 2 2015, 11:16 PM

Change 215539 merged by jenkins-bot:
QA: Temporarily skip basic site scenarios

https://gerrit.wikimedia.org/r/215539

Jdlrobson renamed this task from Assertions in browser tests for non-JavaScript main menu failing to Main menu non-JavaScript behaviour regression.Jun 2 2015, 11:53 PM
Jdlrobson removed a project: Patch-For-Review.
Jdlrobson updated the task description. (Show Details)
Jdlrobson triaged this task as High priority.Jun 3 2015, 4:44 PM
kaldari claimed this task.Jun 5 2015, 9:12 PM
kaldari moved this task from To Do to Doing on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.
gerritbot added a comment.Jun 5 2015, 10:53 PM

Change 216331 had a related patch set uploaded (by Kaldari):
Hide JS-only main menu links when JavaScript is off

https://gerrit.wikimedia.org/r/216331

gerritbot added a comment.Jun 5 2015, 11:19 PM

Change 216331 merged by jenkins-bot:
Hide JS-only main menu links when JavaScript is off

https://gerrit.wikimedia.org/r/216331

phuedx closed this task as Resolved.Jun 10 2015, 6:30 PM
phuedx removed a project: Patch-For-Review.
phuedx added a subscriber: phuedx.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL