Page MenuHomePhabricator

[AG] Make sure an error message is shown each time file-format of the image is not supported
Closed, ResolvedPublic1 Estimated Story Points

Description

Although the tool supports gifs (which was our primary concern and is gone now) it's important to control and make sure that an error message is shown for any other file formats that the tool doesn't support.

Event Timeline

Tobi_WMDE_SW raised the priority of this task from to Medium.
Tobi_WMDE_SW updated the task description. (Show Details)
Tobi_WMDE_SW moved this task from Incoming to Sprint Ready on the TCB-Team (now WMDE-TechWish) board.
Tobi_WMDE_SW added subscribers: Aklapper, Tobi_WMDE_SW.
Tobi_WMDE_SW renamed this task from Attribution Generator: No error message is shown if file-format of the image is not supported to No error message is shown if file-format of the image is not supported.Jun 4 2015, 11:52 AM
Tobi_WMDE_SW raised the priority of this task from Medium to High.
KasiaWMDE lowered the priority of this task from High to Medium.Jun 7 2015, 1:56 PM
KasiaWMDE renamed this task from No error message is shown if file-format of the image is not supported to Make sure an error message is shown each time file-format of the image is not supported.Jun 12 2015, 1:03 PM
KasiaWMDE updated the task description. (Show Details)
KasiaWMDE renamed this task from Make sure an error message is shown each time file-format of the image is not supported to [AG] Make sure an error message is shown each time file-format of the image is not supported.Jun 18 2015, 4:10 PM

It seems this is working, at least I'm getting an appropriate error message when I try this file: https://commons.wikimedia.org/wiki/File:Sel%C3%A7uk_Turkey_2015.webm

"Der Medientyp der angegebenen Datei wird von dieser Applikation momentan leider nicht unterstützt."

We should double check the code if this covers all unsupported file formats and then close this task.

Attribution generator is not checking the actual format (jpeg, png, gif, whatever) of the file but what is checks is the "media type": https://www.mediawiki.org/wiki/Media_type. Specifically, it only processes file of media type "bitmap" or "drawing". If file of other media type is loaded AG responses with the error message that @Tobi_WMDE_SW mentioned above.

As it only considers files already uploaded to some wiki, it does not have to bother about the file formats as it has been taken care on the wiki's side.
So, as I get it it, this feature is working just fine.