Page MenuHomePhabricator

Build a new version of php-luasandbox and hhvm-luasandbox, and deploy to integration hosts
Closed, ResolvedPublic

Description

Event Timeline

Packages built and uploaded on apt.wikimedia.org precise-wikimedia/trusty-wikimedia suites and main component. Integration hosts should be able to get the package via the standard apt-get.

Current states:

php-luasandbox on Ubuntu

salt -t 30  -v --out=txt -C 'G@os:ubuntu and *slave*'  pkg.version,pkg.latest_version php-luasandbox,php-luasandbox
Executing job with jid 20150616112248077841
-------------------------------------------

integration-slave-precise-1013.integration.eqiad.wmflabs: {'pkg.version': '2.0.9', 'pkg.latest_version': '2.0.11precise1'}
integration-slave-precise-1012.integration.eqiad.wmflabs: {'pkg.version': '2.0.9', 'pkg.latest_version': '2.0.11precise1'}
integration-slave-precise-1011.integration.eqiad.wmflabs: {'pkg.version': '2.0.9', 'pkg.latest_version': '2.0.11precise1'}
integration-slave-trusty-1014.integration.eqiad.wmflabs: {'pkg.version': '2.0.8', 'pkg.latest_version': '2.0.11'}
integration-slave-precise-1014.integration.eqiad.wmflabs: {'pkg.version': '2.0.9', 'pkg.latest_version': '2.0.11precise1'}
integration-slave-trusty-1012.integration.eqiad.wmflabs: {'pkg.version': '2.0.8', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1017.integration.eqiad.wmflabs: {'pkg.version': '2.0.9', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1011.integration.eqiad.wmflabs: {'pkg.version': '2.0.8', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1016.integration.eqiad.wmflabs: {'pkg.version': '2.0.9', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1015.integration.eqiad.wmflabs: {'pkg.version': '2.0.9', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1013.integration.eqiad.wmflabs: {'pkg.version': '2.0.9', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1021.integration.eqiad.wmflabs: {'pkg.version': '2.0.11', 'pkg.latest_version': ''}

hhvm-luasandbox on Trusty

integration-saltmaster:~# salt -t 30  -v --out=txt -C 'G@oscodename:trusty and *slave*'  pkg.version,pkg.latest_version hhvm-luasandbox,hhvm-luasandbox
Executing job with jid 20150616112101491416
-------------------------------------------

integration-slave-trusty-1011.integration.eqiad.wmflabs: {'pkg.version': '2.0-8', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1017.integration.eqiad.wmflabs: {'pkg.version': '2.0-8', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1016.integration.eqiad.wmflabs: {'pkg.version': '2.0-8', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1012.integration.eqiad.wmflabs: {'pkg.version': '2.0-8', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1014.integration.eqiad.wmflabs: {'pkg.version': '2.0-8', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1015.integration.eqiad.wmflabs: {'pkg.version': '2.0-8', 'pkg.latest_version': '2.0.11'}
integration-slave-trusty-1021.integration.eqiad.wmflabs: {'pkg.version': '2.0.11', 'pkg.latest_version': ''}
integration-slave-trusty-1013.integration.eqiad.wmflabs: {'pkg.version': '2.0-8', 'pkg.latest_version': '2.0.11'}

Note we have HHVM 3.3.1+dfsg1-1+wm3.1 (i.e. not 3.6)

Updated php-luasandbox:

# salt -t 30  -v --out=txt -C 'G@oscodename:trusty and *slave*'  pkg.install php-luasandbox
integration-slave-trusty-1021.integration.eqiad.wmflabs: {}
integration-slave-trusty-1012.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11', 'old': '2.0.8'}}
integration-slave-trusty-1011.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11', 'old': '2.0.8'}}
integration-slave-trusty-1016.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11', 'old': '2.0.9'}}
integration-slave-trusty-1015.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11', 'old': '2.0.9'}}
integration-slave-trusty-1017.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11', 'old': '2.0.9'}}
integration-slave-trusty-1014.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11', 'old': '2.0.8'}}
integration-slave-trusty-1013.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11', 'old': '2.0.9'}}

# salt -t 30  -v --out=txt -C 'G@oscodename:precise and *slave*'  pkg.install php-luasandbox
integration-slave-precise-1013.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11precise1', 'old': '2.0.9'}}
integration-slave-precise-1012.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11precise1', 'old': '2.0.9'}}
integration-slave-precise-1011.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11precise1', 'old': '2.0.9'}}
integration-slave-precise-1014.integration.eqiad.wmflabs: {'php-luasandbox': {'new': '2.0.11precise1', 'old': '2.0.9'}}

So now I am wondering whether we can bump hhvm-luasandbox from 2.0-8 to 2.0.11 while keeping hhvm 3.3 instead of 3.6. @akosiaris would that be compatible?

So we can not upgrade hhvm-luasandbox from 2.0-8 to 2.0.11 until HHVM itself is upgraded from 3.3.1 to 3.6.1 to provide the proper hhvm-api:

dpkg-deb --info hhvm-luasandbox_2.0.11_amd64.deb |grep Depends
 Depends: hhvm-api-20150212, libc6 (>= 2.17), libgcc1 (>= 1:4.1.1), liblua5.1-0, libstdc++6 (>= 4.1.1)
                   ^^^^^^^^

dpkg-deb --info hhvm-luasandbox_2.0-8_amd64.deb  |grep Depends
 Depends: hhvm-api-20140829, libc6 (>= 2.17), libgcc1 (>= 1:4.1.1), liblua5.1-0, libstdc++6 (>= 4.1.1)
                   ^^^^^^^^

So that is blocked by HHVM upgrade to 3.6.1:

@hashar so is a new package for HHVM a blocker? if so, can you/someone else please post a patchset to our HHVM package with the fix to gmp_init?

I can do that, but I guess it will take more time to me as I'm strongly involved in a high-prio project.

More info here: https://wikitech.wikimedia.org/wiki/HHVM

@hashar so is a new package for HHVM a blocker? if so, can you/someone else please post a patchset to our HHVM package with the fix to gmp_init?

I can do that, but I guess it will take more time to me as I'm strongly involved in a high-prio project.

More info here: https://wikitech.wikimedia.org/wiki/HHVM

@Joe folks found a configuration change that should workaround the gmp_init() error. Apparently there is no need for a new package and I can try bumping the HHVM version on CI to 3.6.x :-]

From T98882 /etc/hhvm/php.ini now has hhvm.hack.lang.iconv_ignore_correct = true which should fix the gmp_init() error.

php-luasandbox has been deployed earlier.

hhvm-luasandbox has been deployed as part of T102616: Upgrade HHVM on CI Trusty slaves from 3.3.1 to 3.6.1

Thank you @Anomie to have reported the issue and @akosiaris for the new packages!