Page MenuHomePhabricator

Refactor WebviewController to use native navigation and tool bars
Closed, ResolvedPublic5 Estimated Story Points

Description

  • WebVC should be able to displayed in a UINavigationController
  • Actions should be handled within the WebViewController
  • Any actions that present a new view controller should be implemented as a modal temporarily
  • Remove all references to “NAV”, top and bottom VCs
  • WebVC should not to expect to be a singleton - it should perform normal instance based setup and tear down.

Event Timeline

Fjalapeno raised the priority of this task from to Needs Triage.
Fjalapeno updated the task description. (Show Details)
Fjalapeno subscribed.

WebVC should not to expect to be a singleton - it should perform normal instance based setup and tear down.

To be clear, the VC shouldn't be a singleton, but the UIWebView probably should. As long as we all agree to only have one UIWebView on screen, we should restrict the app to one to limit resources (as webviews are very resource intensive).

WebVC should not to expect to be a singleton - it should perform normal instance based setup and tear down.

To be clear, the VC shouldn't be a singleton, but the UIWebView probably should. As long as we all agree to only have one UIWebView on screen, we should restrict the app to one to limit resources (as webviews are very resource intensive).

I don’t think that is necessary to make the web view a singleton while making the view controller disposable. That seems to add some complexity. We can just make sure we don’t present the web view controller more than one at a time in the navigation stack. (The same way we don’t present more than one settings view controller at a time).

Sure, just so long as we only have one webview.