Page MenuHomePhabricator
Create Task
Maniphest T101348

GlobalUserPageHooks::onTitleIsAlwaysKnown notably slows down Title::isKnown() calls
Closed, ResolvedPublic
Actions

Description

Title::isKnown via Title::isKnown triggers the TitleIsAlwaysKnown hook. Most of its time is spent inside GlobalUserPageHooks::onTitleIsAlwaysKnown. This kind of check is supposed to be quick. Is there some low hanging fruit in there we can optimise?

flamegraph.png (2,384×972 px, 350 KB)

Related Objects
Search...

Event Timeline

Krinkle created this task.Jun 4 2015, 1:31 AM
Krinkle raised the priority of this task from to Medium.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Performance Issue, GlobalUserPage.
Krinkle subscribed.
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptJun 4 2015, 1:31 AM
Krinkle added a project: Performance-Team.Jun 4 2015, 1:35 AM
Krinkle set Security to None.
Krinkle removed a project: Performance-Team.
Krinkle added a subscriber: Legoktm.
Krinkle moved this task from Tag to Backlog on the Performance Issue board.Jun 10 2015, 10:28 PM
Legoktm added a comment.Jun 10 2015, 10:43 PM

See T88644: Caching and batching of "known" link status and other link info and Tim's comments on https://gerrit.wikimedia.org/r/#/c/188298/

Krinkle moved this task from Backlog to Tag on the Performance Issue board.Jun 18 2015, 12:11 AM
MaxSem added a subtask: Restricted Task.Sep 24 2018, 7:47 PM
MaxSem closed subtask Restricted Task as Resolved.Nov 30 2018, 7:51 PM
tstarling mentioned this in T88644: Caching and batching of "known" link status and other link info.Jun 30 2021, 6:42 AM
tstarling mentioned this in T284274: action=history with a high limit like >= 2000, can be slow and might timeout.Jun 30 2021, 7:00 AM
Krinkle added a project: Performance-Team (Radar).Jun 7 2022, 3:35 PM
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Krinkle closed this task as Resolved.EditedJun 7 2022, 3:58 PM
Krinkle claimed this task.
Krinkle added subscribers: Samwilson, aaron, MaxSem.

From T72585 in 2014 (before this task):

In T72585#746509:

Change 169653 merged by jenkins-bot:
Updates after performance review

https://gerrit.wikimedia.org/r/169653

In T72585#746538:

Change 170363 merged by jenkins-bot:
Further optimize displayGlobalPage()

https://gerrit.wikimedia.org/r/170363

After after this task, which removes most of what showed up in the flame graph above:

I checked both the regular and the reversed flame graph for the last 24h and GlobalUserPage doesn't show up there in the SpecialPage rendering subtree, nor anywhere else. 2022-06-06.excimer-wall.index.svgz

Screenshot 2022-06-07 at 16.59.11.png (2,374×804 px, 172 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits