Page MenuHomePhabricator
Create Task
Maniphest T10136

Trigger hook on page rollback
Closed, ResolvedPublic
Actions

Description

As far as I can see, there is currently no way for an extension to react to a
page being undeleted (restored) or an edit being rolled-back.

This means that extensions which cache meta-data based on the page contents will
go out of sync if either of these situations occur.

I don't know if either of these warrant a new hook, or whether
ArticleInsertComplete (for undelete) and ArticleSave/ArticleSaveComplete (for
rollback) should be re-used.

I am happy to implement a patch for this if someone can advise me on the best
method.

Version: unspecified
Severity: enhancement

Details

Reference
bz8136

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT10649 Hooks needed for metadata tracking
 ResolvedNoneT10136 Trigger hook on page rollback

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:29 PM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz8136.
• bzimport added a subscriber: Unknown Object (MLST).
HappyDog created this task.Dec 3 2006, 4:48 PM
• bzimport added a comment.Dec 3 2006, 10:02 PM

robchur wrote:

New hooks sound appropriate to me.

Hippietrail added a comment.Jan 10 2007, 12:33 AM

Article::onArticleCreate() looks like the right place for a lower-level article
creation hook than 'ArticleInsertComplete'.

However, Article::onArticleCreate() is used as a cache clearing function from
Title.php which makes it a misnomer. I recommend separating it into a function
which reflects its name and calls an 'OnArticleCreate' hook and a new
cache-clearing function with a name to match which can be called from Title.php
when moving articles.

• bzimport added a comment.Jan 18 2007, 7:45 AM

robchur wrote:

'ArticleUndelete' hook added in r19441. Repurposing bug to the rollback hook.

• demon added a comment.Jun 11 2008, 2:02 AM

Handled via ArticleRollbackComplete, as of 1.12.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits