Page MenuHomePhabricator

Mentions are not recognized when more than one section is involved
Closed, ResolvedPublic


Currently, mention notifications are only sent if a change was add-comment (added a comment to an existing section) or new-section-with-comment (added a section)
When someone adds multiple sections, or comments on an existing sections and starts a new section below it, no mention notification will be generated.

Event Timeline

matthiasmullie raised the priority of this task from to Needs Triage.
matthiasmullie updated the task description. (Show Details)
matthiasmullie subscribed.

Change 215885 had a related patch set uploaded (by Matthias Mullie):
Generate mention notifications in more cases

Above patch only adds a test to show the failure. Also added a todo in there on how/where to fix it.

Mattflaschen-WMF renamed this task from Mentions are only recognized in limited cases to Mentions are not recognized when more than one section is involved.Oct 30 2015, 9:40 PM
Mattflaschen-WMF set Security to None.
Mattflaschen-WMF added subscribers: Catrope, XXN.

Change 215885 abandoned by Matthias Mullie:
WIP: Generate mention notifications in more cases

Restricted Application added a subscriber: TerraCodes. · View Herald Transcript

It looks like this was reported a rather long time ago and since lots of work has happened on mention notifications since then!

Addshore claimed this task.

I am going to mark this as resolved due to the work that has been carried out.
I have confirmed a few cases as working

If more cases are missing / not working it might make sense to file new tickets! :)