Page MenuHomePhabricator

Cleanup of Parser::doTableStuff
Closed, ResolvedPublic

Description

Reading that code might give some less "hardcore" people an headake. Following
patch is my attempt to cleanup the code.


Version: 1.9.x
Severity: normal

Details

Reference
bz8141

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:30 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz8141.
bzimport added a subscriber: Unknown Object (MLST).
AzaToth created this task.Dec 3 2006, 11:10 PM

patch cleaning up the code

I have checked with parsertest, and it pass.

attachment doTableStuffFix.patch ignored as obsolete

patch cleaning up the code

Fixing the possible undefined index on row 797, fixed some comments. Also I
ensure that there are enough whitespaces to make everyone happy.

attachment doTableStuffFix.patch ignored as obsolete

patch cleaning up the code

removed the unnecissary variable $tmp_line as it is unnecissary and don't add
to the logic of the code, moved up the attribute code instead in it's place and
use the variable $line again instead in the rest of the block, which for me
makes more sense.

Attached:

leon wrote:

Applied in r18160.