Add gather_list.gl_item_count
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Jun 4 2015, 11:05 PM

Description

Beta: ~~run foreachwikiindblist /srv/mediawiki/all-labs.dblist extensions/Gather/maintenance/updateCounts.php on deployment-bastion~~ done
Production:

~~before the patches in parent go live: log in to terbium, create a local copy of add-gl_item_count.sql, run mwscript sql.php --wiki=<wiki> ~/add-gl_item_count.sql~~ done
after the patches went live, run mwscript extensions/Gather/maintenance/updateCounts.php --wiki=<wiki>; echo 'wfWaitForSlaves();' | mwscript eval.php --wiki=<wiki> on terbium

This needs to be done for each wiki where Gather is enabled.

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T101115 Anon users can access public view from main menu
Resolved	Jdlrobson	T101201 Notification for hamburger and tipsy in menu to call out collections
Resolved	Jdlrobson	T96222 Add a new public collection feed view
Declined	Jdlrobson	T96226 If a user has collections, their last 3 collections show up on their mobile user profile
Declined	None	T98503 No way to query API for 3 most recent public collections from user x
Resolved	Tgr	T97061 API: Allow filtering of collections
Invalid	None	T51188 [DO NOT USE] Schema changes for Wikimedia wikis (tracking) [superseded by #Blocked-on-schema-change]
Resolved	Tgr	T101460 Add gather_list.gl_item_count

Event Timeline

Tgr created this task.Jun 4 2015, 11:05 PM

Tgr claimed this task.

Tgr raised the priority of this task from to Needs Triage.

Tgr updated the task description. (Show Details)

Tgr added projects: Schema-change, Gather, Mobile-Web-Sprint-48-Voyage-of-the-Damned.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 4 2015, 11:05 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.Jun 4 2015, 11:05 PM

Tgr added a parent task: T51188: [DO NOT USE] Schema changes for Wikimedia wikis (tracking) [superseded by #Blocked-on-schema-change].Jun 4 2015, 11:05 PM

Jdlrobson moved this task from To Do to Doing on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.Jun 4 2015, 11:17 PM

The schema change only affects a few wikis[1] and small tables, so imo it can go out at any time.

When running the updateCounts, monitor replication lag, as usual. Probably fine, again, because the tables are small.

[1] testwiki test2wiki enwiki enwikivoyage hewiki

Springle mentioned this in T98490: Add (list, title) index for Gather lists.Jun 5 2015, 1:24 AM

Deployed schema change.

updateCounts must be run after the code is updated (next Tuesday?) It also needs to be run on beta.

• KLans_WMF edited projects, added Mobile-Web-Sprint-49-Wayne's-World; removed Mobile-Web-Sprint-48-Voyage-of-the-Damned.Jun 8 2015, 4:35 PM

• KLans_WMF set Security to None.

• KLans_WMF moved this task from Needs Analysis to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.

Ran foreachwikiindblist /srv/mediawiki/all-labs.dblist extensions/Gather/maintenance/updateCounts.php on deployment-bastion.

Tgr updated the task description. (Show Details)Jun 9 2015, 12:36 AM

Jdlrobson moved this task from Needs triage to This Sprint on the Gather board.Jun 10 2015, 3:16 PM

Seems good to me http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=lists&lstprop=count&lstowner=Jdlrobson&lstminitems=2

Jdlrobson moved this task from Doing to Done on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 12:31 AM

In T101460#1368073, @Jdlrobson wrote:

Seems good to me http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=lists&lstprop=count&lstowner=Jdlrobson&lstminitems=2

It has a bunch of count: 1 items; that should not happen.

And count: 0 items with lstminitems=1. Seems to work correctly with any parameter > 2 though. Probably somehow related to watchlists...

@Tgr oh yes... what needs to be done here then? Does your recent patch fix this?

Jdlrobson moved this task from Done to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 12:39 AM

Tracked in T102573, let's keep this limited to the schema change.

Ran the scripts on production, verified manually in SQL, seems good.

phuedx moved this task from -1 (Needs More Work) to Done on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 9:20 AM

Add gather_list.gl_item_countClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Add gather_list.gl_item_count
Closed, ResolvedPublic
Actions

Related Objects
Search...