Page MenuHomePhabricator

Remove 'wgUseMediaWikiUIEverywhere' and code forks, always using the off/false path
Closed, ResolvedPublic

Description

We decided to use OOUI instead for core, and remove the global $wgUseMediaWikiUIEverywhere, CodeSearch.

Current core code documentation:

/**
 * Temporary variable that applies MediaWiki UI wherever it can be supported.
 * Temporary variable that should be removed when mediawiki ui is more
 * stable and change has been communicated.
 * @since 1.24
 */
$wgUseMediaWikiUIEverywhere = false;

Status Sept 2020, MW core v1.36:

RepoSetting
corefalse
MobileFrontendtrue
edwardspec / mediawiki-moderationfalse (to override MF)
extensions / CookieWarningtrue but just for hooks test
Nikerabbit / mediawiki-extensions-Ainuttrue
skins / WikimediaApiPortaltrue but only referred to in docs
skins / BlueSpiceCalummatrue

Steps

  • Deprecate global
    • Remove it in used repositories
  • Remove it

Event Timeline

Mattflaschen-WMF renamed this task from Remove 'wgUseMediaWikiUIEverywhere', always using the off/false path to Remove 'wgUseMediaWikiUIEverywhere' and code forks, always using the off/false path.
Mattflaschen-WMF raised the priority of this task from to Needs Triage.
Mattflaschen-WMF updated the task description. (Show Details)
Mattflaschen-WMF set Security to None.

Change 633557 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/skins/WikimediaApiPortal@master] Remove 'wgUseMediaWikiUIEverywhere'.

https://gerrit.wikimedia.org/r/633557

Change 633557 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Update installation documentation.

https://gerrit.wikimedia.org/r/633557

Nikerabbit subscribed.

I was expecting to get a styled button using Html::submitButton. Can we at least switch the default value by now?

I was expecting to get a styled button using Html::submitButton. Can we at least switch the default value by now?

You want to enable a massively-deprecated feature?

Html::submitButton could very well be a wrapper that creates OOUI buttons instead of falling back to regular unstyled button by default. Instead, I created something else that implicitly depends on mediawiki-ui and what has to be fixed again in the future.