Page MenuHomePhabricator

Remove 'wgUseMediaWikiUIEverywhere' and code forks, always using the off/false path
Open, Needs TriagePublic

Description

We decided to use OOUI instead for core, and remove the global $wgUseMediaWikiUIEverywhere, CodeSearch.

Current core code documentation:

/**
 * Temporary variable that applies MediaWiki UI wherever it can be supported.
 * Temporary variable that should be removed when mediawiki ui is more
 * stable and change has been communicated.
 * @since 1.24
 */
$wgUseMediaWikiUIEverywhere = false;

Status Sept 2020, MW core v1.36:

RepoSetting
corefalse
MobileFrontendtrue
edwardspec / mediawiki-moderationfalse (to override MF)
extensions / CookieWarningtrue but just for hooks test
Nikerabbit / mediawiki-extensions-Ainuttrue
skins / WikimediaApiPortaltrue but only referred to in docs
skins / BlueSpiceCalummatrue

Steps

  • Deprecate global
    • Remove it in used repositories
  • Remove it

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
ResolvedFlorian
ResolvedFlorian
ResolvedFlorian
ResolvedFlorian
OpenNone
ResolvedNone
DuplicateNone
ResolvedAnomie
ResolvedAnomie
ResolvedTgr
ResolvedAnomie
ResolvedJoe
ResolvedJoe
Resolvedhashar
Resolvedbd808
ResolvedAnomie
ResolvedKrinkle
ResolvedNone
ResolvedJanZerebecki
ResolvedKrinkle
ResolvedTgr
Resolvedmatmarex
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
DuplicateVolker_E
ResolvedJdforrester-WMF
ResolvedPrtksxna
Resolvedmatmarex
ResolvedFlorian
Resolvedmatmarex
Resolvedmatmarex
ResolvedVolker_E
Resolvedmatmarex
Resolvedmatmarex
DeclinedNone
Declinedmatmarex
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
ResolvedEsanders
ResolvedMooeypoo
ResolvedPRODUCTION ERRORMaxSem
ResolvedMooeypoo
ResolvedMooeypoo
ResolvedEsanders
ResolvedPrtksxna
Declinedmatmarex
ResolvedEsanders
Resolvedmatmarex
ResolvedEsanders
ResolvedEsanders
ResolvedEsanders
Resolvedmatmarex
Resolvedmatmarex
ResolvedVolker_E
DeclinedNone
Resolvedmatmarex
Resolvedmatmarex
ResolvedEsanders
Resolvedmatmarex
ResolvedVolker_E
Resolvedmatmarex
ResolvedMainframe98
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
ResolvedVolker_E
ResolvedVolker_E
Resolvedmatmarex
ResolvedVolker_E
ResolvedJdlrobson
ResolvedBUG REPORTmatmarex
Resolvedmatmarex
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedPRODUCTION ERRORNone
OpenNone

Event Timeline

Mattflaschen-WMF renamed this task from Remove 'wgUseMediaWikiUIEverywhere', always using the off/false path to Remove 'wgUseMediaWikiUIEverywhere' and code forks, always using the off/false path.
Mattflaschen-WMF raised the priority of this task from to Needs Triage.
Mattflaschen-WMF updated the task description. (Show Details)
Mattflaschen-WMF set Security to None.

Change 633557 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/skins/WikimediaApiPortal@master] Remove 'wgUseMediaWikiUIEverywhere'.

https://gerrit.wikimedia.org/r/633557

Change 633557 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Update installation documentation.

https://gerrit.wikimedia.org/r/633557

Nikerabbit added a subscriber: Nikerabbit.

I was expecting to get a styled button using Html::submitButton. Can we at least switch the default value by now?

I was expecting to get a styled button using Html::submitButton. Can we at least switch the default value by now?

You want to enable a massively-deprecated feature?

Html::submitButton could very well be a wrapper that creates OOUI buttons instead of falling back to regular unstyled button by default. Instead, I created something else that implicitly depends on mediawiki-ui and what has to be fixed again in the future.