Page MenuHomePhabricator

common job for all repositories that runs structural linting
Closed, DeclinedPublic

Description

We could use a job triggered by all repositories that would enforce some basic checks. Typically linting PHP/json, i18n banana checker ...

Event Timeline

hashar raised the priority of this task from to Needs Triage.
hashar updated the task description. (Show Details)
hashar subscribed.

Seems like the dependencies are backwards here?

Seems like the dependencies are backwards here?

I have set them the over way but seems to me whenever we get that common job implemented that will fix all the blocking tasks :-}

From the CI weekly meeting on Sept 29th 2015.

Seems we could have a central Makefile in integration/config.git. Then have the repositories trigger a single job make-test that would invoke our central Makefile.

The Makefile will automatically detect what kind of commands it can run and do it. For example run npm test when there is a package.json file in the repo.

As this ticket is more about generic checks like is the commit message ok. I created T111181 for the above comment.

Change 242177 had a related patch set uploaded (by Hashar):
Generic test runner entry point

https://gerrit.wikimedia.org/r/242177

The rough idea was https://gerrit.wikimedia.org/r/242177 . However it is nicer for now to have jobs run in parallel.