Page MenuHomePhabricator

Migrate pre-existing images into SDImageCache
Closed, ResolvedPublic5 Estimated Story Points

Description

If a user accesses a saved article while migration is taking place, it should fall through to the normal Image manager logic. As a result, if a user is offline, saved pages images will be broken until the migration is complete.

Do not worry about notifying the user about migration in this patch, UX needs will be evaluated later on and we can add user notifications if needed.

  • Add logic to delete images associated with a page when it is deleted
  • Add background task to migrate images from saved pages into SDWebImage
  • Start background task on launch

Event Timeline

Fjalapeno raised the priority of this task from to Needs Triage.
Fjalapeno updated the task description. (Show Details)
Fjalapeno subscribed.
BGerstle-WMF renamed this task from Migrate pre-existing images into SDWebImageCache to Migrate pre-existing images into SDImageCache.Jul 6 2015, 3:27 PM
BGerstle-WMF updated the task description. (Show Details)

Change 224115 had a related patch set uploaded (by Bgerstle):
Migrate article images from un-migrated save page entries

https://gerrit.wikimedia.org/r/224115

Change 224115 merged by jenkins-bot:
Migrate article images from un-migrated save page entries

https://gerrit.wikimedia.org/r/224115