Page MenuHomePhabricator

Extract exact license info for share a fact cards
Closed, ResolvedPublic2 Estimated Story Points

Description

It is currently misleading to have share a fact cards rendering a default CC by SA for all cards, regardless of the actual image license. We need to extract exact license info from https://www.mediawiki.org/wiki/API:Imageinfo.

@Vibhabamba, the extracted license would replace the existing current CC by SA field?

Event Timeline

KLans_WMF raised the priority of this task from to Needs Triage.
KLans_WMF updated the task description. (Show Details)
KLans_WMF added a subscriber: KLans_WMF.

I think we could adopt the same approach as galleries here.

Rationale for licensing in galleries:

I remember running into cases where no license showed up for a lot of images. This is because it can sometimes be tricky to extract it from the file page.
In order to avoid this, we wanted to always have a fall back.
We used icons instead of spelling the icon out because images may have long descriptions. Carrying an icon calls out the license more clearly for the user.

This is the categorization system which we created for galleries.

License_Icon_Legend.png (470×1 px, 18 KB)

Here a set of licenses corresponds to an icon.
If we cannot detect the exact license, we fall back to the third category, which is fair use.

This icon categorization approach is also consistent with what mediaviewer does.
Compare icons for the Van Gogh lead image on ios with desktop mediaviewer.
https://en.wikipedia.org/wiki/Vincent_van_Gogh#/media/File:Vincent_van_Gogh_-_Self-Portrait_-_Google_Art_Project_(454045).jpg

@KLans_WMF @Dbrant who is picking up this task?
I would like to sync up with Engg.

@Vibhabamba not sure who would pick this up on the iOS side (could be anyone, depending who's available). Maybe sun w/Corey or Bryan.

@KLans_WMF likely this will be moved into the next sprint.

Based on guidance from @Slaporte and discussion with @Mholloway & @Moushira the first immediate step is:

  1. Although we are legally compliant but we could take steps to address user concerns reported on the discussion page for Share a fact
  2. An immediate solution as part of this patch is to get a bit more specific with the license. Instead of the general CC-BY-SA icon, we will present a category icon based on the legend provided, consistent with the gallery UX in apps.
  3. There is no change in the perceived user experience (no delays/ loading indicators etc)
  4. For cases where we are unable to detect a license we will fall back to the Fair use category.

License_Icon_Legend.png (470×1 px, 18 KB)

@KLans_WMF This is no longer blocked by design and can be bumped to the next sprint.

Icons are currently being used in the gallery and should be re-used from there.
Please let me know if you need SVG dupes.

Fjalapeno renamed this task from BLOCKED by DESIGN: Extract exact license info for share a fact cards to Extract exact license info for share a fact cards.Jul 5 2015, 6:52 PM
JMinor raised the priority of this task from Lowest to Medium.Feb 19 2016, 10:30 PM
JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.
JMinor lowered the priority of this task from Medium to Low.May 9 2016, 10:48 PM
JMinor moved this task from Backlog to Needs Design on the iOS-app-v5.1.0-Saturn board.
Josve05a added a subscriber: Josve05a.

Can this please be worked on this year? Just because something is legally allowed under fair use or not (I saw that someone mentioned in another ticket that this was legally ok per legal), that does not mean we should do it this way, because we actually have a mission, believe it or not....Sorry, I just don't like to see this ticket reach year 2 on Phabricator.

JMinor claimed this task.