Page MenuHomePhabricator

Ref generating templates show references lists when edited
Closed, ResolvedPublic8 Story Points

Description

Make a trivial edit to the infobox on https://en.wikipedia.org/wiki/Jesse_Owens?veaction=edit and apply. Observe that a reflist now appears at the top of the page.

Event Timeline

Esanders created this task.Jun 5 2015, 8:18 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: VisualEditor, Parsoid.
Esanders added a subscriber: Esanders.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2015, 8:18 PM
ssastry added a subscriber: ssastry.Jun 5 2015, 9:04 PM

The problem is that we auto-generate <references/>, but this is not the right thing to do in all scenarios.
A simple solution for this would be to add a autogen-refs = false param to the wt2html apis.

Arlolra triaged this task as Normal priority.Jul 7 2015, 2:03 AM
Arlolra added a subscriber: Arlolra.
Jdforrester-WMF edited a custom field.

It seems best for VE to strip the references subtree by looking for mw:Extension/References from the DOM it receives from Parsoid. We'll leave bodyOnly as is.

Right, but that's only half of the solution for VisualEditor, the other half is putting those updated references in the references list where they belong.

It seems best for VE to strip the references subtree by looking for mw:Extension/References from the DOM it receives from Parsoid. We'll leave bodyOnly as is.

Right, but that's only half of the solution for VisualEditor, the other half is putting those updated references in the references list where they belong.

I didn't understand this. Doesn't VE already insert newly added <ref>s in the references list? Wouldn't it be the same for references added by templates? Can you explain a bit more what you mean here?

Indeed it doesn't do this for references added by templates. Templates are entirely "opaque" and VE doesn't handle anything inside them in any way.

Jdforrester-WMF renamed this task from Ref generating templates show reflists when edited to Ref generating templates show references lists when edited.Feb 22 2016, 10:08 PM
Esanders changed the point value for this task from 0 to 8.Mar 26 2016, 10:36 PM

Change 279730 had a related patch set uploaded (by Esanders):
Filter out auto-generated reference lists

https://gerrit.wikimedia.org/r/279730

Change 279730 merged by jenkins-bot:
Filter out auto-generated reference lists

https://gerrit.wikimedia.org/r/279730

He7d3r added a subscriber: He7d3r.Feb 28 2018, 3:38 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 28 2018, 3:38 PM