Page MenuHomePhabricator

GeSHi claims to support GESHI_NORMAL_LINE_NUMBERS but doesn't
Closed, ResolvedPublic

Description

The documentation (https://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi) claims that the line attribute can be empty (default=fancy) or explicitly set to fancy or default. Fancy means every nth line number (default n=5) is bolded.

Firstly this is a lie, the code only detects the presence of 'line' and sets fancy mode regardless of the value.

Secondly there is no way to customise the value of n.

Event Timeline

Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: SyntaxHighlight.
Esanders added a subscriber: Esanders.

Personally I think highlighting every nth line number is a fairly useless feature, and we simplify things by making line a boolean attribute that enables normal line numbering.

Jdforrester-WMF set Security to None.

Change 216983 had a related patch set uploaded (by Esanders):
Use normal line numbers

https://gerrit.wikimedia.org/r/216983

Change 216983 merged by jenkins-bot:
Use normal line numbers

https://gerrit.wikimedia.org/r/216983