Page MenuHomePhabricator

Interacting with table generated by {{#ask}} throws Uncaught TypeError
Closed, DeclinedPublic

Description

If I open
https://wikitech.wikimedia.org/wiki/Nova_Resource:Revscoring?debug=1
and pass the mouse over the "Modification date" I get the following error

TypeError: $.browser is undefined

from the line moz = $.browser.mozilla, of
https://wikitech.wikimedia.org/static/1.26wmf8/extensions/SemanticMediaWiki/resources/jquery/jquery.qtip.js

Event Timeline

He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added a subscriber: He7d3r.

from the line moz = $.browser.mozilla, of
https://wikitech.wikimedia.org/static/1.26wmf8/extensions/SemanticMediaWiki/resources/jquery/jquery.qtip.js

/*! qTip2 - Pretty powerful tooltips - v2.0.0 - 2012-09-10

That's because wikitech uses an outdated version of SemanticMediaWiki, a version that was still using qTip v2.0.0.

qTip fixed jQuery 1.9 compatibility (removal of $.browser) two years ago in qTip v2.1.0 (July 2013).
http://qtip2.com/changelog

SemanticMediaWiki updated their copy of qTip in May 2014.
https://github.com/SemanticMediaWiki/SemanticMediaWiki/commit/fe9ffb06aeec
.. which was released in SemanticMediaWiki 2.0 in August 2014.
https://github.com/SemanticMediaWiki/SemanticMediaWiki/releases/tag/2.0

wmf-branch is configured with a hardcoded "SemanticMediaWiki 1.8.x"
https://github.com/wikimedia/mediawiki-tools-release/blob/4ca8c6c1/make-wmf-branch/config.json#L171

Looks like it's time for an update. Any breaking changes?

Krinkle renamed this task from TypeError on table headers to Interacting with table generated by {{#ask}} throws Uncaught TypeError.Jun 7 2015, 2:24 PM
Krinkle triaged this task as High priority.
Krinkle removed a project: JavaScript.
Krinkle set Security to None.

wmf-branch is configured with a hardcoded "SemanticMediaWiki 1.8.x"
https://github.com/wikimedia/mediawiki-tools-release/blob/4ca8c6c1/make-wmf-branch/config.json#L171

Looks like it's time for an update. Any breaking changes?

Duplicate of T62886? Sounds like this would be automatically resolved as soon as that one is, so...