Page MenuHomePhabricator

Fix database error "Flow\Repository\TreeRepository::insert: Can't reopen table: 'unittest_flow_tree_node'"
Closed, ResolvedPublic

Description

This Database warning occurs 69 times in all mediawiki-extensions-hhvm builds for extensions unrelated to Flow

https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/19862/artifact/log/mw-dberror.log/*view*/

Mon Jun 8 13:49:36 UTC 2015 integration-slave-trusty-1013 jenkins_u0_mw-unittest_ Flow\Repository\TreeRepository::insert localhost 1137 Can't reopen table: 'unittest_flow_tree_node' (localhost) INSERT INTO unittest_flow_tree_node (tree_descendant_id,tree_ancestor_id,tree_depth) SELECT '#«‰\"à(·yü€',tree_ancestor_id,tree_depth + 1 FROM unittest_flow_tree_node WHERE tree_descendant_id = '#÷Æ&ÑÁ# qh'
Mon Jun 8 13:49:39 UTC 2015 integration-slave-trusty-1013 jenkins_u0_mw-unittest_ Flow\Repository\TreeRepository::insert localhost 1137 Can't reopen table: 'unittest_flow_tree_node' (localhost) INSERT INTO unittest_flow_tree_node (tree_descendant_id,tree_ancestor_id,tree_depth) SELECT '7M¼%ÓÕ¿»Uê',tree_ancestor_id,tree_depth + 1 FROM unittest_flow_tree_node WHERE tree_descendant_id = '7M¼%ËÕ¿»Uê'

Most've been recently introduced because our logs were almost empty a week ago.

Details

Related Gerrit Patches:

Event Timeline

Krinkle created this task.Jun 8 2015, 2:03 PM
Krinkle raised the priority of this task from to Normal.
Krinkle updated the task description. (Show Details)
Krinkle added subscribers: Krinkle, hashar.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 8 2015, 2:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matthiasmullie set Security to None.
matthiasmullie added a comment.EditedJun 8 2015, 4:00 PM

This is an acceptable error for Flow: insert-select doesn't work on temporary tables (as used for MW unit tests) and if it fails (with 1137) we execute a (non-atomic) alternative.
I can add a MW_PHPUNIT_TEST conditional to reduce the logspam.

However, this wasn't recently introduced - we've known about it & have been checking that db error code for awhile.
All I can think of would be that mediawiki-extensions-hhvm wasn't running mysql all that time, but I think it has been for awhile now?

Change 216728 had a related patch set uploaded (by Matthias Mullie):
Skip query that's known to fail under certain conditions

https://gerrit.wikimedia.org/r/216728

Change 216728 merged by jenkins-bot:
Skip query that's known to fail under certain conditions

https://gerrit.wikimedia.org/r/216728

Catrope closed this task as Resolved.Jun 8 2015, 6:03 PM
Catrope moved this task from Needs Review to Done on the Collaboration-Team-Sprint-C-2015-06-17 board.
Catrope added a subscriber: Catrope.