Page MenuHomePhabricator
Create Task
Maniphest T101721

(5) Move page actions (icons & page-issues) styling to stable
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

  • Icons moved to right
  • Page issues restyled
  • Update browser tests
  • Careful with the cached HTMLs, apply JS fixes.

Trello tasks:
https://trello.com/c/26TidjN6/11-3-page-styling-to-beta
https://trello.com/c/DHDvgwf8/146-new-page-styling-minus-lead-images-to-stable

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+82 -187Page actions and issues from beta to stable
Customize query in gerrit

Related Objects
Search...

Event Timeline

• KHammerstein created this task.Jun 8 2015, 4:55 PM
• KHammerstein raised the priority of this task from to Needs Triage.
• KHammerstein updated the task description. (Show Details)
• KHammerstein added a project: Readers-Web-Backlog.
• KHammerstein added subscribers: • KHammerstein, JKatzWMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2015, 4:55 PM
• KHammerstein updated the task description. (Show Details)Jun 8 2015, 4:59 PM
• KHammerstein set Security to None.
• KHammerstein updated the task description. (Show Details)Jun 8 2015, 5:12 PM
• KHammerstein updated the task description. (Show Details)
• KHammerstein updated the task description. (Show Details)Jun 8 2015, 5:16 PM
Jdlrobson moved this task from Incoming to 2016-17 Q2 on the Readers-Web-Backlog board.Jun 9 2015, 7:22 PM
KLans_WMF updated the task description. (Show Details)Jun 10 2015, 7:01 PM
Jhernandez renamed this task from Move header styling to stable to Move headeing (icons & page-issues) styling to stable.Jun 17 2015, 6:29 PM
Jhernandez renamed this task from Move headeing (icons & page-issues) styling to stable to Move heading (icons & page-issues) styling to stable.
Jhernandez updated the task description. (Show Details)Jun 17 2015, 6:32 PM
KLans_WMF renamed this task from Move heading (icons & page-issues) styling to stable to (5) Move heading (icons & page-issues) styling to stable.Jun 17 2015, 6:34 PM
KLans_WMF updated the task description. (Show Details)
KLans_WMF moved this task from 2016-17 Q2 to 2015-16 Q3 on the Readers-Web-Backlog board.
phuedx added a subscriber: phuedx.Jun 17 2015, 7:08 PM

The page actions elements will have to be moved to the top of the .pre-content element so that the styles can be applied without tweaking. This reordering supports moving the page actions inline and to the far right of the page in tablet and desktop. We should take the time to evaluate whether this is strictly required and it can't be achieved another way.

• KHammerstein updated the task description. (Show Details)Jun 18 2015, 9:43 PM
KLans_WMF edited a custom field.Jun 22 2015, 4:24 PM
KLans_WMF added a project: Reading-Web-Sprint-50-The-X-Files.Jun 22 2015, 4:38 PM
KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 4:40 PM
Jdlrobson moved this task from 2015-16 Q3 to Old Unorganized Resolved Tasks on the Readers-Web-Backlog board.Jun 25 2015, 9:52 PM
phuedx renamed this task from (5) Move heading (icons & page-issues) styling to stable to (5) Move page actions (icons & page-issues) styling to stable.Jun 26 2015, 5:16 PM
• rmoen claimed this task.Jun 29 2015, 9:55 PM
• rmoen moved this task from To Do to Doing on the Reading-Web-Sprint-50-The-X-Files board.
• rmoen removed • rmoen as the assignee of this task.Jun 30 2015, 4:17 PM
• rmoen moved this task from Doing to To Do on the Reading-Web-Sprint-50-The-X-Files board.
phuedx claimed this task.Jul 1 2015, 1:59 PM
phuedx moved this task from To Do to Doing on the Reading-Web-Sprint-50-The-X-Files board.
gerritbot added a subscriber: gerritbot.Jul 1 2015, 7:57 PM

Change 222178 had a related patch set uploaded (by Phuedx):
Page actions and issues from beta to stable

https://gerrit.wikimedia.org/r/222178

gerritbot added a project: Patch-For-Review.Jul 1 2015, 7:57 PM
phuedx moved this task from Doing to -1 (Needs More Work) on the Reading-Web-Sprint-50-The-X-Files board.Jul 1 2015, 8:09 PM
Jhernandez removed a project: Readers-Web-Backlog.Jul 2 2015, 9:51 AM
phuedx moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jul 2 2015, 10:22 AM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-50-The-X-Files board.Jul 2 2015, 7:05 PM
Jdlrobson added a subtask: T104338: [Regression] Last modified bar padding inconsistent between mobile/tablet and desktop.Jul 2 2015, 9:06 PM
phuedx closed subtask T104338: [Regression] Last modified bar padding inconsistent between mobile/tablet and desktop as Resolved.Jul 3 2015, 11:40 AM
phuedx moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jul 3 2015, 1:45 PM
gerritbot added a comment.Jul 3 2015, 6:09 PM

Change 222178 merged by jenkins-bot:
Page actions and issues from beta to stable

https://gerrit.wikimedia.org/r/222178

phuedx mentioned this in rMEXT48d994905a29: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 3 2015, 6:10 PM
phuedx mentioned this in rEMFR1d182d14d27c: Page actions and issues from beta to stable.
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jul 3 2015, 6:12 PM
Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 3 2015, 7:00 PM
phuedx closed this task as Resolved.Jul 6 2015, 2:10 PM

Verified on BC.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-50-The-X-Files board.Jul 6 2015, 2:10 PM
phuedx removed a project: Patch-For-Review.Jul 6 2015, 6:49 PM
Jdlrobson mentioned this in T112309: Remove all the cache related FIXMEs.Sep 11 2015, 6:33 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL