Page MenuHomePhabricator
Create Task
Maniphest T101723

Use NavigationView from new android.support.design library.
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

For consistency and simplicity, we should use the new NavigationView in the design support library:

https://developer.android.com/reference/android/support/design/widget/NavigationView.html

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use NavigationView from android.support.design library for nav drawerapps/android/wikipediamaster+376 -595
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dbrant created this task.Jun 8 2015, 5:04 PM
Dbrant raised the priority of this task from to Needs Triage.
Dbrant updated the task description. (Show Details)
Dbrant added a project: Wikipedia-Android-App-Backlog.
Dbrant subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2015, 5:04 PM
Dbrant added a parent task: T102271: Use more Material Design components in the app..Jun 19 2015, 1:22 PM
Dbrant triaged this task as Medium priority.Jul 1 2015, 3:17 PM
Dbrant moved this task from Needs Triage to Product Backlog on the Wikipedia-Android-App-Backlog board.
MBinder_WMF moved this task from Product Backlog to Next Sprint on the Wikipedia-Android-App-Backlog board.Jul 10 2015, 5:56 PM
MBinder_WMF set Security to None.Jul 17 2015, 5:37 PM
MBinder_WMF edited a custom field.
Dbrant added a parent task: T104623: As a designer, I want to know which link in the left nav receives most engagement..Jul 17 2015, 5:45 PM
Dbrant moved this task from Next Sprint to Current Sprint on the Wikipedia-Android-App-Backlog board.Jul 21 2015, 12:10 PM
Dbrant added a project: Mobile-App-Sprint-62-Android-Summer-Breeze.Jul 22 2015, 2:42 AM
• Mholloway claimed this task.Jul 22 2015, 3:31 PM
• Mholloway moved this task from To Do to Doing on the Mobile-App-Sprint-62-Android-Summer-Breeze board.
gerritbot subscribed.Jul 24 2015, 2:39 PM

Change 226721 had a related patch set uploaded (by Mholloway):
Use NavigationView from android.support.design library for nav drawer

https://gerrit.wikimedia.org/r/226721

gerritbot added a project: Patch-For-Review.Jul 24 2015, 2:39 PM
• Mholloway moved this task from Doing to Code Review on the Mobile-App-Sprint-62-Android-Summer-Breeze board.Jul 24 2015, 3:17 PM
• bearND subscribed.EditedJul 27 2015, 11:46 PM

Screenshot from PS6:

device-2015-07-27-173802.png (1×600 px, 72 KB)

FYI, the "Overstay your stay!" is a fake W0 banner message of the W0 TEST1 network.

Dbrant awarded a token.Jul 27 2015, 11:48 PM
• Mholloway added a comment.Jul 27 2015, 11:51 PM

Hmm, that doesn't seem right. How did you obtain that message?

• bearND added a comment.EditedJul 27 2015, 11:52 PM

Just updated my comment above. Sorry, saw you question later.

• Mholloway added a comment.Jul 28 2015, 1:27 PM

As for a W0 icon, is that something to ping the design team on, or should I come up with something?

As far as I know, there's no universal symbol for either "money" or "free of charge"...

• Mholloway added a comment.Jul 28 2015, 7:09 PM

Updated screenshots

Screenshot_2015-07-28-15-06-24.png (1×720 px, 59 KB)

Screen Shot 2015-07-28 at 3.08.21 PM.png (900×1 px, 575 KB)

• Mholloway mentioned this in T107338: Add shadow to new NavigationView-based nav drawer in pre-Lollipop versions.Jul 29 2015, 8:19 PM
gerritbot added a comment.Jul 30 2015, 9:31 PM

Change 226721 merged by jenkins-bot:
Use NavigationView from android.support.design library for nav drawer

https://gerrit.wikimedia.org/r/226721

• bearND moved this task from Code Review to Design Signoff on the Mobile-App-Sprint-62-Android-Summer-Breeze board.Jul 30 2015, 10:11 PM
• bearND mentioned this in rAPAW231f78c36b30: Use NavigationView from android.support.design library for nav drawer.Jul 30 2015, 10:14 PM
• Vibhabamba subscribed.Jul 31 2015, 8:41 PM

Signed off by Design

• Vibhabamba moved this task from Design Signoff to QA Signoff on the Mobile-App-Sprint-62-Android-Summer-Breeze board.Jul 31 2015, 8:41 PM
MBinder_WMF moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Sprint-62-Android-Summer-Breeze board.Aug 3 2015, 6:40 PM
MBinder_WMF moved this task from Ready for Signoff to QA Signoff on the Mobile-App-Sprint-62-Android-Summer-Breeze board.
Dbrant edited projects, added Mobile-App-Sprint-63-Android-Europium; removed Mobile-App-Sprint-62-Android-Summer-Breeze.Aug 3 2015, 7:20 PM
Dbrant moved this task from To Do to QA Signoff on the Mobile-App-Sprint-63-Android-Europium board.
Etonkovidova subscribed.Aug 7 2015, 9:59 PM

Checked with 2.0.108-alpha-2015-08-07 on Nexus5(Android 5.1)

Etonkovidova moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Sprint-63-Android-Europium board.Aug 7 2015, 9:59 PM
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Sprint-63-Android-Europium board.Aug 10 2015, 12:23 PM
Dbrant closed this task as Resolved.Aug 17 2015, 1:40 PM
Dbrant moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Aug 17 2015, 1:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits