[Bug] When editing quantities, do not put the unit label in the input field
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	daniel
	Jun 8 2015, 7:02 PM

Description

When generating a plain text representation of a quantity value for editing, that representation should not contain the unit label (for now), since we cannot parse that (yet). QuantityFormatter::OPT_APPLY_UNIT can be used to control this.

This is related to T95425 (conceptually different, but it related to the same code and mechanisms).

Details

	Subject	Repo	Branch	Lines +/-
	Use QuantityInput expert	mediawiki/extensions/Wikibase	master	+18 -9

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T56318 Quantity datatype (tracking)
Open	Feature	None	T68580 Better support for exact values in Quantity DataType
Resolved		daniel	T140997 When guessing quantity precision from digits, use the +/-0.5 rule rather than the +/-1 rule
Open		None	T133042 Quantity datatype precision (tracking)
Resolved		Lydia_Pintscher	T115269 [Story] When a Quantity is entered with no uncertainty/bounds given, do not guess uncertainty/bounds until needed.
Resolved		thiemowmde	T115270 Allow QuantityValue objects to have empty/no bounds set
Resolved		daniel	T105623 [Task] Investigate quantification of quantity precision (+/- 1 or +/- 0.5)
Open		None	T77977 [Epic] Unit support
Resolved		• Jonas	T98172 [Story] Implement Unit Selector widget
Resolved		None	T101754 [Bug] When editing quantities, do not put the unit label in the input field
Resolved		Lydia_Pintscher	T142086 [Task] announce quantity changes
Resolved		Ladsgroup	T142087 [Task] prepare bot for quantity change fixes
Open		None	T112247 [RFC] Create a "number" datatype for exact values
Resolved		Ladsgroup	T154168 Quantity changes broke ORES

Event Timeline

daniel created this task.Jun 8 2015, 7:02 PM

daniel raised the priority of this task from to Needs Triage.

daniel updated the task description. (Show Details)

daniel added projects: Wikidata, MediaWiki-extensions-WikibaseClient.

daniel added a subscriber: daniel.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2015, 7:02 PM

Lydia_Pintscher triaged this task as Medium priority.Jun 12 2015, 1:21 PM

Lydia_Pintscher added a parent task: T77977: [Epic] Unit support .

Lydia_Pintscher set Security to None.

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.

@Jonas: Not sure how this relates to what you've done already. Please have a look.

This will be fixed with this patch https://gerrit.wikimedia.org/r/#/c/222597/3

• Jonas added a parent task: T98172: [Story] Implement Unit Selector widget.Aug 13 2015, 8:50 PM

Lydia_Pintscher added a project: Patch-For-Review.Aug 13 2015, 9:03 PM

• Jonas renamed this task from When editing quantities, do not put the unit label in the input field to [Bug] When editing quantities, do not put the unit label in the input field.Aug 14 2015, 7:44 AM

Jc3s5h added a subscriber: Jc3s5h.Aug 14 2015, 2:58 PM

Change 222597 had a related patch set uploaded (by Addshore):
Use QuantityInput expert

https://gerrit.wikimedia.org/r/222597

• Jonas closed this task as Resolved.Aug 25 2015, 9:04 AM

Change 222597 merged by jenkins-bot:
Use QuantityInput expert

https://gerrit.wikimedia.org/r/222597

thiemowmde mentioned this in rMEXT1d112d7059a1: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 25 2015, 9:06 AM

Addshore mentioned this in rEWBAaa01c1992286: Use QuantityInput expert.Aug 25 2015, 9:08 AM