Page MenuHomePhabricator
Create Task
Maniphest T101765

Update mobile main menu code to get rid of legacy cruft
Closed, ResolvedPublic
Actions

Description

The main menu code in MobileFrontend has a lot of old cruft from back before it used a Hogan template. This should be cleaned up so that the code is simpler and easier to navigate.

Details

SubjectRepoBranchLines +/-
Hygiene: Update main menu code to get rid of legacy cruftmediawiki/extensions/MobileFrontendmaster+140 -81
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Jun 8 2015, 8:43 PM
kaldari claimed this task.
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added projects: Web-Team-Backlog, Technical-Debt.
kaldari subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2015, 8:43 PM
gerritbot subscribed.Jun 8 2015, 8:43 PM

Change 216382 had a related patch set uploaded (by Kaldari):
Hygiene: Update main menu code to get rid of legacy cruft

https://gerrit.wikimedia.org/r/216382

gerritbot added a project: Patch-For-Review.Jun 8 2015, 8:43 PM
kaldari added a project: Mobile-Web-Sprint-49-Wayne's-World.Jun 8 2015, 8:44 PM
kaldari set Security to None.
kaldari moved this task from Needs Analysis to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 8 2015, 9:50 PM
• KLans_WMF moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Jun 8 2015, 10:24 PM
Jdlrobson moved this task from -1 (Needs More Work) to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 9 2015, 10:11 PM
gerritbot added a comment.Jun 9 2015, 10:12 PM

Change 216382 merged by jenkins-bot:
Hygiene: Update main menu code to get rid of legacy cruft

https://gerrit.wikimedia.org/r/216382

kaldari mentioned this in rEMFRf0cac08ea668: Hygiene: Update main menu code to get rid of legacy cruft.Jun 9 2015, 10:12 PM
Diffusion mentioned this in rMEXTba426890ef73: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 9 2015, 10:12 PM
• Forrestbot added a project: WMF-deploy-2015-06-16_(1.26wmf10).Jun 9 2015, 11:00 PM
• Forrestbot subscribed.
kaldari moved this task from Doing to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 10 2015, 11:43 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 11 2015, 6:38 PM
Jdlrobson moved this task from Ready for Signoff to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.
Jdlrobson closed this task as Resolved.Jun 11 2015, 7:00 PM
Jdlrobson moved this task from Code Review to Done on the Mobile-Web-Sprint-49-Wayne's-World board.
Jdlrobson subscribed.
phuedx removed a project: Patch-For-Review.Jun 16 2015, 11:39 AM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL