Page MenuHomePhabricator

Styles horribly broken as CSS values less than 1 are being rounded to 0
Closed, ResolvedPublic

Description

Everything is horribly broken. At a quick glance, something in the build process is clobbering almost all values measured in 'em', so, almost all values basically.

This happened after I did npm install, and is also visible on https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/, so I blame rGOJUd24df4157db0: build: Updating development dependencies.

This is blocking the next release.

Event Timeline

matmarex created this task.Jun 8 2015, 8:44 PM
matmarex raised the priority of this task from to Unbreak Now!.
matmarex updated the task description. (Show Details)
matmarex added a project: OOUI.
matmarex added subscribers: matmarex, Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2015, 8:44 PM

Change 216850 had a related patch set uploaded (by Jforrester):
Follow-up d24df41: Undo broken upgrade of grunt-csscomb

https://gerrit.wikimedia.org/r/216850

Change 216850 merged by jenkins-bot:
Follow-up d24df41: Undo broken upgrade of grunt-csscomb

https://gerrit.wikimedia.org/r/216850

Jdforrester-WMF renamed this task from Everything horribly broken to Styles horribly broken as CSS values less than 1 are being rounded to 0.Jun 8 2015, 9:05 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Jun 10 2015, 2:27 AM