Page MenuHomePhabricator
Create Task
Maniphest T101797

MobileDiff doesn't parse edit summary
Closed, ResolvedPublic
Actions

Description

Diffs like https://en.m.wikipedia.org/wiki/Special:MobileDiff/665979469 shows a lot of messy wikitext, e.g.:

Screen Shot 2015-06-09 at 01.32.39.png (318×1 px, 83 KB)

Reverting possible vandalism by [[Special:Contributions/..|..]] to version by ... False positive? [[User:ClueBot NG/FalsePositives|Report it]]. Thanks, [[User:ClueBot NG|ClueBot NG]]. (2266825) (Bot)

Note that edit summaries have a narrow restricted subset of allowed syntaxes. And desktop diffs do render them.

The mobile page history page also doesn't render the links, but at least it doesn't display syntax either. The mobile history page seems to use the parsed html and then strips html for plain text:
https://en.m.wikipedia.org/wiki/Special:History/Wikipedia

Screen Shot 2015-06-09 at 01.33.39.png (510×1 px, 67 KB)

That would be preferable to unexpectedly exposing wikitext, though ideally it would just be rendered. As far as I know the API already exposes this alongside the raw edit summary.

Note that there is one place where Mobile-Web does render the edit summary. Namely, the oldid pages:
https://en.m.wikipedia.org/w/index.php?title=Wikipedia&oldid=665979469.

Screen Shot 2015-06-09 at 01.32.12.png (398×1 px, 130 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Render edit summaries on Special:MobileDiffmediawiki/extensions/MobileFrontendmaster+17 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jun 9 2015, 12:34 AM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added a project: MobileFrontend.
Krinkle added subscribers: Krinkle, Aklapper.
Restricted Application added a project: Web-Team-Backlog-Archived. · View Herald TranscriptJun 9 2015, 12:34 AM
• Tbayer subscribed.Jun 13 2015, 12:19 AM

I think it should render wikilinks, because they often contain vital information for editors. E.g. in the above example "False positive? Report it" will likely cause a lot of frustration in case there is no way to find out how to actually report such a false positive to the operator of the anti-vandalism bot. In many other cases, editors use the field to point each other to discussion venues, help pages, policy pages etc. that are hard to find when going by the name alone, especially for less experienced users.

Florian claimed this task.Jun 13 2015, 5:40 PM
Florian triaged this task as Medium priority.
gerritbot subscribed.Jun 13 2015, 5:50 PM

Change 218022 had a related patch set uploaded (by Florianschmidtwelzow):
Render edit summaries on Special:MobileDiff

https://gerrit.wikimedia.org/r/218022

gerritbot added a project: Patch-For-Review.Jun 13 2015, 5:50 PM
phuedx moved this task from Incoming to 2017-18 Q3 on the Web-Team-Backlog-Archived board.Jun 15 2015, 10:33 AM
gerritbot added a comment.Jun 17 2015, 10:09 PM

Change 218022 merged by jenkins-bot:
Render edit summaries on Special:MobileDiff

https://gerrit.wikimedia.org/r/218022

Diffusion mentioned this in rMEXTfbee2f5f3911: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 17 2015, 10:09 PM
Jdlrobson mentioned this in rEMFRede25e9e92f5: Render edit summaries on Special:MobileDiff.Jun 17 2015, 10:09 PM
• Forrestbot added a project: WMF-deploy-2015-06-16_(1.26wmf10).Jun 17 2015, 11:00 PM
• Forrestbot subscribed.
Jdlrobson closed this task as Resolved.Jun 18 2015, 10:22 PM
Jdlrobson subscribed.
Jdforrester-WMF edited projects, added WMF-deploy-2015-06-23_(1.26wmf11); removed WMF-deploy-2015-06-16_(1.26wmf10).Jun 22 2015, 9:11 PM
Jdforrester-WMF set Security to None.
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
• Phabricator_maintenance moved this task from 2017-18 Q3 to 2014-15 Q4 on the Web-Team-Backlog-Archived board.Mar 7 2018, 1:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits