Page MenuHomePhabricator

TalkPageManager::getTalkPageManager unconditionally adds flow-bot group
Closed, ResolvedPublic

Description

Every call to TalkPageManager::getTalkPageManager() causes an unconditional call to $user->addGroup( 'flow-bot' ); , which User.php implements as an INSERT IGNORE without checking if the user is already in the group.

Event Timeline

Catrope raised the priority of this task from to High.
Catrope updated the task description. (Show Details)
Catrope added subscribers: Aklapper, Legoktm, aaron, Catrope.
Legoktm added a project: good first task.
Legoktm set Security to None.

Change 217151 had a related patch set uploaded (by Legoktm):
Only add the Flow talk page manager account to the flow-bot group if not in it

https://gerrit.wikimedia.org/r/217151

Change 217151 merged by jenkins-bot:
Only add the Flow talk page manager account to the flow-bot group if not in it

https://gerrit.wikimedia.org/r/217151