Page MenuHomePhabricator

TalkPageManager::getTalkpageManager can create user
Open, HighPublic

Description

TalkPageManager::getTalkpageManager() has a name that doesn't exactly suggest it'll write to the database, but it lazy-creates and promotes a user. I think it would be better to do this from update.php or some other sort of maintenance script.

Event Timeline

Catrope created this task.Jun 9 2015, 8:24 PM
Catrope raised the priority of this task from to High.
Catrope updated the task description. (Show Details)
Catrope added subscribers: Aklapper, Legoktm, aaron, Catrope.
Catrope renamed this task from TalkPageManager::getTalkPageManager can create user to TalkPageManager::getTalkpageManager can create user.May 10 2016, 10:16 PM
Catrope updated the task description. (Show Details)
Catrope set Security to None.

Per 2016-05-10 meeting, we don't think this currently can occur on a GET request, but it's too easy to do wrong.