D3. EnsureFlowRevision() is called when viewing an unconverted page in an occupied namespace
Closed, ResolvedPublic
Actions

Description

Related to T101881: Unknown topic error when viewing unconverted page in occupied namespace, if you create a wikitext page in a namespace and then have Flow occupy that namespace, viewing that page (a GET request) will cause ensureFlowRevision() to be called, which will edit the page (which obviously causes database writes) and also call getTalkPageManager() which can cause additional writes due to T101888: TalkPageManager::getTalkPageManager unconditionally adds flow-bot group and T101889: TalkPageManager::getTalkpageManager can create user

Details

	Subject	Repo	Branch	Lines +/-
	Don't write when we're reading data	mediawiki/extensions/Flow	master	+0 -32

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	aaron	T88445 MediaWiki active/active datacenter investigation and work (tracking)
Resolved	matthiasmullie	T94028 DB master connections requested by Flow on GET/HEAD requests
Resolved	None	T101887 Flow issues write queries on GET (read) requests
Resolved	matthiasmullie	T101890 D3. EnsureFlowRevision() is called when viewing an unconverted page in an occupied namespace

Event Timeline

Catrope created this task.Jun 9 2015, 8:29 PM

Catrope raised the priority of this task from to High.

Catrope updated the task description. (Show Details)

Catrope added projects: StructuredDiscussions, Collaboration-Team-Triage.

Catrope added subscribers: Aklapper, Legoktm, Catrope.

matthiasmullie claimed this task.Jun 16 2015, 5:52 PM

matthiasmullie set Security to None.

Catrope moved this task from Untriaged to Ready for next sprint on the Collaboration-Team-Triage board.Jun 16 2015, 5:54 PM

Catrope moved this task from Ready for next sprint to Sprint D (temporary for meeting) on the Collaboration-Team-Triage board.

Change 218689 had a related patch set uploaded (by Matthias Mullie):
Don't write when we're reading data

https://gerrit.wikimedia.org/r/218689

gerritbot added a project: Patch-For-Review.Jun 16 2015, 6:54 PM

• DannyH added a project: Collaboration-Team-Sprint-D-2015-06-30.Jun 16 2015, 7:04 PM

• DannyH moved this task from Sprint D (temporary for meeting) to Current workboard on the Collaboration-Team-Triage board.

• DannyH renamed this task from ensureFlowRevision() is called when viewing an unconverted page in an occupied namespace to D3. EnsureFlowRevision() is called when viewing an unconverted page in an occupied namespace.Jun 16 2015, 7:20 PM

• DannyH moved this task from Sprint D - ends July 1 to Needs Review on the Collaboration-Team-Sprint-D-2015-06-30 board.

I can't confirm the bug report (it doesn't attempt to convert it on read), but I think https://gerrit.wikimedia.org/r/#/c/218689/ should fix this.
The only other places ensureFlowRevision() is still present are:

SubmissionHandler::commit: guaranteed to only be run on POST
OccupationListener::onAfterInsert: only runs after executing actions that can only be performed on POST
TalkpageImportOperation::import: manually triggered
WorkflowPageIdUpdateGenerator::update (maintenance script FlowUpdateWorkflowPageId.php): manually triggered
tests