Maniphest T101977

Templates with language annotations not converted properly by VE
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Krenair
	Jun 10 2015, 12:30 PM

Description

Which has no effect on the wikitext you get back to save, because you didn't edit the transclusion itself.

I just ran into this myself: https://meta.wikimedia.org/w/index.php?title=IRC/Channels&diff=12412456&oldid=12002898
In this case I copied the {{Channel}} from the wikimedia-design entry, and it copied correctly as a template, but I could still edit the contents directly (as I could before copying), and thus the transclusion itself remained the same.

Might be caused by Parsoid?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Give TranclusionNodes a matchFunction so they beat LanguageAnnotations	mediawiki/extensions/VisualEditor	master	+26 -0

Customize query in gerrit

Related Objects

Mentioned In: rEVED965a5dde8935: Give TranclusionNodes a matchFunction so they beat LanguageAnnotations

Event Timeline

Krenair created this task.Jun 10 2015, 12:30 PM

Krenair raised the priority of this task from to Needs Triage.

Krenair updated the task description. (Show Details)

Krenair added projects: VisualEditor, Parsoid.

Krenair subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2015, 12:30 PM

The HTML seems okay, looks like a VE bug.

Esanders renamed this task from VE lets you directly edit contents of meta.wikimedia.org's {{Channel}} template at [[IRC/Channels]], rather than the template itself to Templates with language annotations not converted properly by VE.Jun 10 2015, 1:27 PM

Esanders added a subscriber: Catrope.Jun 10 2015, 1:46 PM

Simplest HTML:

<span dir="ltr" about="#mwt1" typeof="mw:Transclusion" data-mw="{}">content</span>

LanguageAnnotation uses a match function (+ tag name) to find lang or dir attributes, this matches before TransclusionNode which uses an RDFa tag (+ tag name)

Match order in the model registry:

tag, rdfaType and func specified
rdfaType and func specified
tag and func specified
func specified
tag and rdfaType specified
rdfaType specified
tag specified
nothing specified

Krenair added a project: VisualEditor-MediaWiki-Templates.Jun 10 2015, 1:56 PM

Change 218620 had a related patch set uploaded (by Esanders):
Give TranclusionNodes a matchFunction so they beat LanguageAnnotations

https://gerrit.wikimedia.org/r/218620

gerritbot added a project: Patch-For-Review.Jun 16 2015, 1:12 PM

Change 218620 merged by jenkins-bot:
Give TranclusionNodes a matchFunction so they beat LanguageAnnotations

https://gerrit.wikimedia.org/r/218620

Esanders mentioned this in rEVED965a5dde8935: Give TranclusionNodes a matchFunction so they beat LanguageAnnotations.Jun 24 2015, 11:53 PM

Jdforrester-WMF closed this task as Resolved.Jun 24 2015, 11:55 PM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.

https://gerrit.wikimedia.org/r/218620 (branch master): WMF-deploy-2015-06-30_(1.26wmf12)

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jun 30 2015, 12:50 AM

Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM

Templates with language annotations not converted properly by VEClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Templates with language annotations not converted properly by VE
Closed, ResolvedPublic8 Estimated Story Points
Actions