Page MenuHomePhabricator

Add @covers annotations to MobileFrontend PHPUnit tests
Closed, ResolvedPublic

Description

Context

@Legoktm is generating hourly code coverage reports for a couple of extensions (T71685). MobileFrontend got added to that list but its tests aren't annotated with the appropriate @covers tags so the report isn't helpful at all (T71685#1332687).

Event Timeline

phuedx raised the priority of this task from to Needs Triage.
phuedx updated the task description. (Show Details)
phuedx added subscribers: phuedx, Legoktm.
phuedx set Security to None.
phuedx moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
Jdlrobson triaged this task as Medium priority.Sep 16 2015, 6:40 PM
Jdlrobson added a subscriber: Jdlrobson.

We used to care a lot about coverage of JS, and once the hype has died down, no one cares anymore. I'd say the same will happen to the PHP code.

Change 276899 had a related patch set uploaded (by Jdlrobson):
Hygiene: Add some @cover tags

https://gerrit.wikimedia.org/r/276899

Done.
Bit curious though to why we are not seeing updates in https://tools.wmflabs.org/coverage/MobileFrontend/extensions_MobileFrontend.html given we already have @covers tags.

Change 276899 merged by jenkins-bot:
Hygiene: Add some @cover tags

https://gerrit.wikimedia.org/r/276899

Signing off. We won't see the benefit of doing this until T71685 is complete.