Page MenuHomePhabricator
Create Task
Maniphest T102021

D4. Edit patrolling links in grouped RC (CA)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Timestamp links should go to the correct oldid links in grouped RC.

grouped rc oldid link.jpg (757×290 px, 274 KB)

See T94452 for more info.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix timestamp link in grouped RC linesSbissonmediawiki/extensions/Flowmaster+56 -9
Add 'EnhancedChangesListModifyLineData' hookSbissonmediawiki/coremaster+75 -19
[WIP] Add 'EnhancedChangesList::getTimestampLink' hookSbissonmediawiki/coremaster+50 -25
[WIP] Fix timestamp link on Enhanced RCSbissonmediawiki/extensions/Flowmaster+58 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

• DannyH created this task.Jun 10 2015, 5:34 PM
• DannyH raised the priority of this task from to Medium.
• DannyH updated the task description. (Show Details)
• DannyH added projects: Collaboration-Team-Triage, StructuredDiscussions.
• DannyH moved this task to Team discussion on the Collaboration-Team-Triage board.
• DannyH subscribed.
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptJun 10 2015, 5:34 PM
• DannyH updated the task description. (Show Details)Jun 10 2015, 6:14 PM
• DannyH set Security to None.
• DannyH edited a custom field.
• DannyH moved this task from Team discussion to Ready for next sprint on the Collaboration-Team-Triage board.
• DannyH updated the task description. (Show Details)Jun 10 2015, 6:18 PM
• DannyH updated the task description. (Show Details)
Catrope mentioned this in T94452: C2. Implement patrolling other people's edits in Flow.Jun 11 2015, 11:14 PM
Catrope moved this task from Ready for next sprint to Sprint D (temporary for meeting) on the Collaboration-Team-Triage board.Jun 15 2015, 11:42 PM
• DannyH renamed this task from Edit patrolling links in grouped RC to Edit patrolling links in grouped RC (CA).Jun 15 2015, 11:42 PM
• DannyH added a parent task: T99117: Turn Flow on for Catalan's Viquipèdia talk namespace.
• DannyH added a project: Collaboration-Team-Sprint-D-2015-06-30.Jun 16 2015, 7:04 PM
• DannyH moved this task from Sprint D (temporary for meeting) to Current workboard on the Collaboration-Team-Triage board.
• DannyH renamed this task from Edit patrolling links in grouped RC (CA) to D4. Edit patrolling links in grouped RC (CA).Jun 16 2015, 7:22 PM
Catrope moved this task from Sprint D - ends July 1 to Needs Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 19 2015, 12:02 AM
Catrope moved this task from Needs Review to Sprint D - ends July 1 on the Collaboration-Team-Sprint-D-2015-06-30 board.
matthiasmullie claimed this task.Jun 19 2015, 12:52 PM
matthiasmullie moved this task from Sprint D - ends July 1 to In Development on the Collaboration-Team-Sprint-D-2015-06-30 board.
matthiasmullie added a comment.Jun 23 2015, 11:28 AM

EnhancedChangesList.php, L303-378 is what builds the output HTML for individual lines.
L334-339 format this specific link (from $params in L320-324)

Most straightforward solution would probably be to break apart the rendering of the individual lines into a separate method (it's part of a 200+ lines method) and - in there - introduce a new hook (similar to EnhancedChangesList::getLogText) that would allow Flow to alter the links/text.

matthiasmullie removed matthiasmullie as the assignee of this task.Jun 23 2015, 11:28 AM
matthiasmullie moved this task from In Development to Sprint D - ends July 1 on the Collaboration-Team-Sprint-D-2015-06-30 board.
SBisson claimed this task.Jun 24 2015, 5:21 PM
SBisson moved this task from Sprint D - ends July 1 to In Development on the Collaboration-Team-Sprint-D-2015-06-30 board.
gerritbot subscribed.Jun 25 2015, 3:08 PM

Change 220766 had a related patch set uploaded (by Sbisson):
Add 'EnhancedChangesList::getTimestampLink' hook

https://gerrit.wikimedia.org/r/220766

gerritbot added a project: Patch-For-Review.Jun 25 2015, 3:08 PM
gerritbot added a comment.Jun 25 2015, 3:18 PM

Change 220769 had a related patch set uploaded (by Sbisson):
[WIP] Fix timestamp link on Enhanced RC

https://gerrit.wikimedia.org/r/220769

gerritbot added a comment.Jun 25 2015, 3:39 PM

Change 220769 abandoned by Sbisson:
[WIP] Fix timestamp link on Enhanced RC

Reason:
See https://gerrit.wikimedia.org/r/220780

https://gerrit.wikimedia.org/r/220769

gerritbot added a comment.Jun 25 2015, 7:13 PM

Change 220931 had a related patch set uploaded (by Sbisson):
[WIP] Add 'EnhancedChangesList::getRecentChangeEntryLineData' hook

https://gerrit.wikimedia.org/r/220931

gerritbot added a comment.Jun 25 2015, 8:05 PM

Change 220766 abandoned by Sbisson:
[WIP] Add 'EnhancedChangesList::getTimestampLink' hook

Reason:
New approach: https://gerrit.wikimedia.org/r/#/c/220931/1

https://gerrit.wikimedia.org/r/220766

gerritbot added a comment.Jun 25 2015, 8:06 PM

Change 220953 had a related patch set uploaded (by Sbisson):
[WIP] Fix timestamp link in grouped RC lines

https://gerrit.wikimedia.org/r/220953

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 25 2015, 11:07 PM
gerritbot added a comment.Jun 26 2015, 8:02 PM

Change 220931 merged by jenkins-bot:
Add 'EnhancedChangesListModifyLineData' hook

https://gerrit.wikimedia.org/r/220931

Legoktm mentioned this in rMW28f2fe8a2235: Add 'EnhancedChangesListModifyLineData' hook.Jun 26 2015, 8:02 PM
• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-06-30_(1.26wmf12).Jun 26 2015, 9:00 PM
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 26 2015, 10:26 PM
gerritbot added a comment.Jun 26 2015, 10:27 PM

Change 220953 merged by jenkins-bot:
Fix timestamp link in grouped RC lines

https://gerrit.wikimedia.org/r/220953

Diffusion mentioned this in rMEXTf0d56d786075: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Jun 26 2015, 10:28 PM
SBisson mentioned this in rEFLW2273e6ba902f: Fix timestamp link in grouped RC lines.Jun 26 2015, 10:28 PM
He7d3r subscribed.Jun 27 2015, 5:54 PM
• DannyH added a project: Collaboration-Team-Sprint-E-Everywhere-2015-07-14.Jun 30 2015, 7:40 PM
• DannyH moved this task from Sprint E - ends July 14 to QA Review on the Collaboration-Team-Sprint-E-Everywhere-2015-07-14 board.
Etonkovidova subscribed.Jun 30 2015, 11:04 PM

T104399 is filed.

Etonkovidova added a comment.Jun 30 2015, 11:07 PM

Checked in beta - Timestamp links for Grouped patrolled edits correctly redirect to pages with [Mark this page as patrolled] .

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 30 2015, 11:08 PM
Catrope moved this task from QA Review to Product Review on the Collaboration-Team-Sprint-E-Everywhere-2015-07-14 board.Jul 1 2015, 5:37 PM
• DannyH closed this task as Resolved.Jul 2 2015, 4:33 PM
• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-E-Everywhere-2015-07-14 board.
• DannyH moved this task from Current workboard to Resolved on the Collaboration-Team-Triage board.Jul 6 2015, 5:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits