Page MenuHomePhabricator
Create Task
Maniphest T102032

Link-local addresses omitted from IP::isPublic()
Closed, ResolvedPublic
Actions

Description

Link-local addresses should be included in the list of CIDR ranges checked for in IP::isPublic(). I spoke with @csteipp and some other people on IRC and determined that these were inadvertently omitted from the list. I'll submit a patch.

Details

SubjectRepoBranchLines +/-
Check for link-local addresses in isPublicmediawiki/coremaster+27 -10
Customize query in gerrit

Related Objects

Event Timeline

• dpatrick created this task.Jun 10 2015, 6:34 PM
• dpatrick raised the priority of this task from to Needs Triage.
• dpatrick updated the task description. (Show Details)
• dpatrick added subscribers: • dpatrick, • csteipp.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2015, 6:34 PM
gerritbot subscribed.Jun 10 2015, 7:09 PM

Change 217328 had a related patch set uploaded (by Dpatrick):
Check for link-local addresses in isPublic

https://gerrit.wikimedia.org/r/217328

gerritbot added a project: Patch-For-Review.Jun 10 2015, 7:09 PM
Legoktm assigned this task to • dpatrick.Jun 10 2015, 7:11 PM
Legoktm added a project: MediaWiki-General.
Legoktm set Security to None.
gerritbot added a comment.Jun 12 2015, 11:36 PM

Change 217328 merged by jenkins-bot:
Check for link-local addresses in isPublic

https://gerrit.wikimedia.org/r/217328

• dpatrick mentioned this in rMWa0616269a103: Check for link-local addresses in isPublic.Jun 12 2015, 11:37 PM
• Forrestbot added projects: WMF-deploy-2015-06-16_(1.26wmf10), MW-1.26-release.Jun 13 2015, 2:01 AM
• Forrestbot subscribed.
• dpatrick closed this task as Resolved.Jun 18 2015, 10:48 PM
• dpatrick triaged this task as Medium priority.
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL