Maniphest T102046

[Regression] Edit icon(the pencil) is displayed on the left side
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Jun 10 2015, 8:26 PM

Description

2.0.102-alpha-2015-06-09 - was testing on a tablet.

Screenshot_2015-06-10-13-05-46.jpg (1×800 px, 600 KB)

Note: I did not switch to RTL languages - neither for System language, nor for Wikipedia language. Also, I checked the case when 'Use system language' option is turned Off, and Wikipedia language is selected as English.

Details

	Subject	Repo	Branch	Lines +/-
	Fix edit pencil position when switching from RTL to LTR.	apps/android/wikipedia	master	+20 -5

Customize query in gerrit

Related Objects

Mentioned In: rAPAW0f77368cca8a: Fix edit pencil position when switching from RTL to LTR.
Mentioned Here: rAPAWa4a9a6593f6e: Add active state to article edit pencil icons

Event Timeline

Etonkovidova created this task.Jun 10 2015, 8:26 PM

Etonkovidova raised the priority of this task from to Needs Triage.

Etonkovidova updated the task description. (Show Details)

Etonkovidova subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2015, 8:26 PM

Ciencia_Al_Poder added a project: Wikipedia-Android-App-Backlog.Jun 10 2015, 8:28 PM

Ciencia_Al_Poder set Security to None.

Etonkovidova renamed this task from [Regression] Edit icon(the pencil icon) is displayed on the left side to [Regression] Edit icon(the pencil) is displayed on the left side.Jun 10 2015, 8:35 PM

This can be reproduced reliably from a clean install:

View any article on English Wikipedia, note edit button is on the right as it should be
Change Wikipedia Language to an RTL language
Change Wikipedia Language back to English
Visit the same article, observe that the edit button is now on the left
Visit more articles and note that the edit button remains on the left

Screenshot_2015-06-24-09-36-49.png (2×1 px, 2 MB)

Screenshot_2015-06-24-09-39-11.png (2×1 px, 2 MB)

Forgot to add that this bug is present in the production version.

Dbrant triaged this task as High priority.Jun 26 2015, 3:05 PM

Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.

Dbrant subscribed.

+1, if this is a regression, it's not a recent one. This issue occurs prior to the recent edit pencil icon changes, a4a9a6593f6ed0fb8e84efa27791c2bbe188525a.

Dbrant merged a task: T105523: The pencil icons still displayed in RTL position after returning back to LTR .Jul 17 2015, 2:54 PM

Change 225323 had a related patch set uploaded (by Dbrant):
Fix edit pencil position when switching from RTL to LTR.

https://gerrit.wikimedia.org/r/225323

gerritbot added a project: Patch-For-Review.Jul 17 2015, 3:24 PM

Dbrant claimed this task.Jul 17 2015, 3:24 PM

Dbrant added a project: Mobile-App-Sprint-61-Android-Beach-Boys.

Dbrant moved this task from To Do to Code Review on the Mobile-App-Sprint-61-Android-Beach-Boys board.

Change 225323 merged by jenkins-bot:
Fix edit pencil position when switching from RTL to LTR.

https://gerrit.wikimedia.org/r/225323

• bearND mentioned this in rAPAW0f77368cca8a: Fix edit pencil position when switching from RTL to LTR..Jul 17 2015, 9:08 PM

• bearND moved this task from Code Review to Done on the Mobile-App-Sprint-61-Android-Beach-Boys board.Jul 17 2015, 9:21 PM

Dbrant closed this task as Resolved.Jul 21 2015, 11:59 AM

Dbrant moved this task from Bug Backlog to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Jul 21 2015, 12:08 PM

	F183228: Screenshot_2015-06-24-09-36-49.png
	Jun 24 2015, 4:45 PM

	F183229: Screenshot_2015-06-24-09-39-11.png
	Jun 24 2015, 4:45 PM

	F177614: Screenshot_2015-06-10-13-05-46.jpg
	Jun 10 2015, 8:26 PM

[Regression] Edit icon(the pencil) is displayed on the left sideClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[Regression] Edit icon(the pencil) is displayed on the left side
Closed, ResolvedPublic
Actions