Maniphest T102157

Gather create collection workflow broken
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 11 2015, 6:59 PM

Tags

Referenced Files

	F178014: Gather create a collection.mov
	Jun 11 2015, 6:59 PM

Subscribers

Description

Click the create collection button at the bottom of Gather page. Then enter a broken workflow (note it still works fine from star)

Two issues:

The edit screen doesn't disappear after creating a collection
Uncaught TypeError: Cannot read property 'id' of null

See video:

Gather create a collection.mov2 MBDownload

Details

	Subject	Repo	Branch	Lines +/-
	Fix create collection workflow	mediawiki/extensions/Gather	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned In: rEGAT3780e406281f: Fix create collection workflow
rMEXT417cff6d71f8: Updated mediawiki/extensions Project: mediawiki/extensions/Gather…
T99922: Updating my Gather collection with additional articles and saving made it empty.

Event Timeline

Jdlrobson created this task.Jun 11 2015, 6:59 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Mobile-Web-Sprint-49-Wayne's-World.

Jdlrobson moved this task to Needs Analysis on the Mobile-Web-Sprint-49-Wayne's-World board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2015, 6:59 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 11 2015, 6:59 PM

Jdlrobson mentioned this in T99922: Updating my Gather collection with additional articles and saving made it empty..

phuedx triaged this task as Unbreak Now! priority.Jun 15 2015, 4:57 PM

phuedx set Security to None.

FYI @JKatzWMF given this wasn't bumped in priority it looks like this problem is going to make it on to production.

Jdlrobson updated the task description. (Show Details)Jun 15 2015, 10:26 PM

@jldrobson shoot, just saw this. I am seeing additional issues:

title and description dont show up in edit screen
clicking the pencil brings me to edit and when i hit save my changes are gone (0 items in colleciton)

Jdlrobson claimed this task.Jun 15 2015, 11:20 PM

Jdlrobson moved this task from To Do to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.

Change 218554 had a related patch set uploaded (by Jdlrobson):
Fix create collection workflow

https://gerrit.wikimedia.org/r/218554

gerritbot added a project: Patch-For-Review.Jun 15 2015, 11:55 PM

Jdlrobson moved this task from Doing to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 12:16 AM

• bmansurov moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 12:26 AM

Change 218554 merged by jenkins-bot:
Fix create collection workflow

https://gerrit.wikimedia.org/r/218554

Diffusion mentioned this in rMEXT417cff6d71f8: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 16 2015, 12:28 AM

Jdlrobson mentioned this in rEGAT3780e406281f: Fix create collection workflow.Jun 16 2015, 12:28 AM

https://gerrit.wikimedia.org/r/218554 (branch master): WMF-deploy-2015-06-16_(1.26wmf10)

Verified this on BC.

@Jdlrobson: Is that WMF-deploy project accurate or does 218554 need to be backported?

phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 11:37 AM

phuedx removed a project: Patch-For-Review.

This was merged late Monday PST. I think we can wait till Thursday, this bug only impacts beta users going through the collections page.

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM