Page MenuHomePhabricator

wpExistingTags not passed in request if multiple revisions are selected
Closed, ResolvedPublic

Description

wpExistingTags is not passed in the request at Special:EditTags if multiple revisions are selected.
It follows that the option to remove all tags cannot work.
Also, users are prompted to add/remove tags that they cannot add/remove.
I think we should check beforehand and only propose them tags they can add/remove.
I had done this in commit 201905 but will split it off since it's not related to the main issue of that commit.

Event Timeline

Cenarium raised the priority of this task from to Low.
Cenarium updated the task description. (Show Details)
Cenarium added a subscriber: Cenarium.

Change 217718 had a related patch set uploaded (by Cenarium):
Fixes for Special:EditTags

https://gerrit.wikimedia.org/r/217718

Only appears to affect non-JavaScript users...

I'm getting the error with JS enabled.

Change 217718 merged by jenkins-bot:
Pass wpExistingTags in the request when multiple revisions are selected

https://gerrit.wikimedia.org/r/217718

Yes, you're right, it does even affect JS users. Anyway, it is fixed now.